feat: backport fix for #266 to Craft 3 #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue described in #266 also affects Craft 3 version of this plugin. So this PR back-ports the fix as is.
What we usually do in our own custom modules when it comes to potentially off-loading to the queue, is to always run the job. But conditionally on the queue.
So, in this case we would have done:
This way both paths end up doing the same work. Now if
Scout::$plugin->getSettings()->queue === false
, the extra work that the Job does does not get executed.I didn't think I should "pollute" this PR with that, but I could put this in a new PR if interested?