Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons are Disabled - Uncaught Invariant Violation: getNodeFromInstance: Invalid argument. #60

Closed
taydotis opened this issue Jul 4, 2016 · 53 comments

Comments

@taydotis
Copy link

taydotis commented Jul 4, 2016

I've successfully gotten the elements to render on the page, but none of the buttons work. Upon entering a valid email address, I am able to at least switch between signin/signup/forgot, but I can never submit any of these forms.

I have had this problems on a few build outs, including trying to run superlumen's base system. A friend of mine had the forms working in one repository, but I could not get that same repository to run on my system. Similarly, superlumen's build had the same error on my friend's computer. We were not able to see any obvious environment differences.

This is on Meteor 1.3.4.1.

@limratana
Copy link

I am the aforementioned friend. I used two separate OS X installations. They differred in node and npm versions and likely how they were installed. On one machine my repo worked but superlumen's did not. On the other both did not work. By 'not work', I mean in the same manner as tr0lyat described.

@matb33
Copy link

matb33 commented Jul 5, 2016

This just started happening to me as well. Works fine in dev environment, doesn't work in production. So far have tracked it down to Field.jsx's triggerUpdate method, specifically let node = ReactDOM.findDOMNode(this);

@sarasate
Copy link

sarasate commented Jul 5, 2016

Seems to be a problem with the latest react version. Downgrade to react 15.1.0 solves it for now.

@taydotis
Copy link
Author

taydotis commented Jul 5, 2016

@sarasate ah yes, requiring version 15.1.0 works for me. Thank you!

I do get a minor glitch where if the field was completed with autofill then it doesn't register as having an email entered, but that is far more agreeable than the form not working at all.

@matb33
Copy link

matb33 commented Jul 5, 2016

I had the issue with both 15.1.0 and 15.2.0. What did it for me was to get rid of the code that caused it, which was commented as being for "backwards-compat":

import { Accounts } from 'meteor/std:accounts-ui'

class Field extends Accounts.ui.Field {
  triggerUpdate () {
    const { onChange } = this.props
    if (this.input) {
      onChange({ target: { value: this.input.value } })
    }
  }
}

shoetten added a commit to shoetten/participate that referenced this issue Jul 5, 2016
@nadeemja
Copy link

nadeemja commented Jul 9, 2016

Dear @timbrandin,

Would you consider releasing a Beta or RC version including pull-requests #55 and #58 at your earliest convenience?

Apologies for such a direct ask. It's urgent.

I thank you and all the contributors for all the hard work that went into this great package.

@firrae
Copy link

firrae commented Jul 14, 2016

If we could get this fixed that would be great. As @nadeemja said, sorry for such an ask, but it is pretty urgent that this gets fixed as it's fully breaking.

@shoetten
Copy link
Contributor

Until this is resolved, i would suggest using @matb33's suggestion, if you're stuck in development. You could clone this into the packages directory of your meteor app, for convenience.
For now, it has worked for me just fine, but i haven't tested in thoroughly..

@nadeemja
Copy link

Dear @timbrandin,

I respectfully ask if you could advise the community on whether to await a timely release or to move on a with a fork.

Once again, many thanks for your and everyones dedication.

@yanickrochon
Copy link

Indeed, this should be resolved ASAP, and should not require clones, etc.

+1

And if @timbrandin has no time to address this, perhaps a contributor should be assigned to do so instead.

@nadeemja
Copy link

nadeemja commented Aug 4, 2016

Tested with react 15.3.0.
Still does not work.

From his public activity log, it appears that @timbrandin is actively contributing to Meteor/Apollo related projects. For this I'm grateful.

However, it would seem that this repo might no longer be a priority of his.
Hopefully we can get some advice from @timbrandin himself on what to do.

Regards,
Nadeem

@fIa5h
Copy link

fIa5h commented Aug 18, 2016

+1

@jshimko
Copy link

jshimko commented Aug 20, 2016

@timbrandin Any update here? This seems like a fairly simple fix and it's been a blocker for updating React for about a month and a half now.

@PolGuixe
Copy link
Collaborator

@timbrandin this is quite a pain. Could this be fixed as soon as possible. :)

@nadeemja
Copy link

Guys. I have some bad news.

I've mailed everyone at studiointeract and every single time I've got a "could not be delivered" response in return.

I've done this over some time span - same thing.

This likely means that studiointeract is no more. Nobody is listening to us from them.

We should fork this repo. Anyone up for the task?

@timbrandin
Copy link
Member

timbrandin commented Aug 27, 2016 via email

@nadeemja
Copy link

Thanks, Tim! :)

PS. None of your @studiointeract or @Findwise emails are working. I'm guessing reaching out to you on twitter was what came trough?

@nadeemja
Copy link

nadeemja commented Sep 5, 2016

Did you get a chance to take a look, @timbrandin? :)

@PolGuixe
Copy link
Collaborator

PolGuixe commented Sep 5, 2016

I have been waiting for it a long time as well. Would be nice to have a fix. I have been working on a Material-UI package, which I would like to publish and start using in production as soon as possible.

Does anybody has a fork with a fix? Or could propose a PR?

@matb33
Copy link

matb33 commented Sep 5, 2016

You don't have to wait for the fix, you can use the code snippet I posted earlier and re-export, and make sure to import your patched version of Accounts.

@matb33
Copy link

matb33 commented Sep 5, 2016

Perhaps something like this:

import { Accounts, STATES } from 'meteor/std:accounts-ui'

class Field extends Accounts.ui.Field {
  triggerUpdate () {
    const { onChange } = this.props
    if (this.input) {
      onChange({ target: { value: this.input.value } })
    }
  }
}

Accounts.ui.Field = Field

export { Accounts, STATES }
export default Accounts

@PolGuixe
Copy link
Collaborator

PolGuixe commented Sep 6, 2016

@matb33 this solution works with this package alone.

But when I am trying to use it with the package I am working on: https://atmospherejs.com/zetoff/accounts-material-ui

I am getting this error:

TypeError: Cannot read property 'trim' of undefined
    at LoginForm.handleChange (LoginForm.jsx:173)

Seems like value is not defined.

@PolGuixe
Copy link
Collaborator

PolGuixe commented Sep 7, 2016

@matb33 to avoid the error above I had to modify it slightly:

class Field extends Accounts.ui.Field {
    triggerUpdate() {
        const {onChange} = this.props
        let value = this.input.value;

        if (value === undefined) {
            value = '';
        } else {
            // do nothing
        }

        if (this.input) {
            onChange({target: {
                    value
                }})
        }
    }
}

If the value of input is undefined, the value is set to ''. I don't think it is a good fix, but it works. What do you think?

@timbrandin any idea how to solve it better?

@PolGuixe
Copy link
Collaborator

@scyu16 which alternatives are you considering?

Is anyone willing to maintain the package?

@timbrandin would you accept collaborators?

@timbrandin
Copy link
Member

Of course, if anyone wants to help it'd be great.

Skickat från min iPhone

19 sep. 2016 kl. 15:04 skrev PolGuixe notifications@github.com:

@scyu16 which alternatives are you considering?

Is anyone willing to maintain the package?

@timbrandin would you accept collaborators?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@scyu16
Copy link

scyu16 commented Sep 20, 2016

@PolGuixe Still need to do some research. I should be able to update you in a week when I have something. I hate to switch, but really can't wait any more after two-month wait and don't have spare time to look into the fixes.

@stolinski
Copy link

+1

@scyu16
Copy link

scyu16 commented Oct 7, 2016

@PolGuixe Sorry for getting back late. Have you found a solution yet? This link suggest okgrow:accounts-ui-react as alternative. @nadeemja do you think if your fork is mature enough to be merged to the master branch? Thanks.

@nadeemja
Copy link

nadeemja commented Oct 7, 2016

Scyu16, I have dropped using this package.

@PolGuixe
Copy link
Collaborator

PolGuixe commented Oct 7, 2016

@scyu16 I Don't think that I'll go back to blaze. I'll prefer a pure React Package.

@nadeemja, Which package are you using?

@nadeemja
Copy link

nadeemja commented Oct 8, 2016

I'm using https://github.com/okgrow/accounts-ui-react

It works. Is maintained. What more can you ask for?

@SachaG
Copy link
Collaborator

SachaG commented Oct 9, 2016

@nadeemja correct me if I'm wrong, but it looks like this is just a React wrapper for the Blaze widget. Meaning using this package will force you to also load the entire Blaze library in your app. Not ideal imo.

@firrae
Copy link

firrae commented Oct 9, 2016

@SachaG you are correct on that, it does indeed use Blaze under the hood. I'm curious if anyone else has written a fully React package yet? Might be something a group from here could work on unless that's already being done.

@PolGuixe
Copy link
Collaborator

@firrae, Could we just update and maintain this package? or it would be better to start a new one?

@firrae
Copy link

firrae commented Oct 10, 2016

@PolGuixe personally speaking updating this package is likely the best option as @timbrandin seemed open to it. In the event that doesn't work well, then a new one is the best bet. The trick is finding someone to hold the project and make sure it is kept going can be difficult as seen in this case.

Personally, I was thinking of building my own package, but there are a lot of things already in place in this package (ie. Router integrations). I know a few people have created solutions and if those are pulled in then this can be revived. Otherwise, there are a few other things that should be reworked under the hood to bring it up to the standard in React 15+ but it's kind of a hard thing to get excited about working on if it's dead and a new package is going to come up.

To add onto this, I think the best end case is either this or a new package is taken in by MDG and made "official" and kept up to date with their help. Blaze seems mostly dead at this point with most new projects I've seen are going to React or Angular, and with that happening it seems weird that we are still required to use MDG's Blaze package if we want something quick and simple.

@SachaG
Copy link
Collaborator

SachaG commented Oct 10, 2016

I don't think this package will ever be made official, but it would be nice if @timbrandin could give a few more people commit rights to the repo.

@firrae
Copy link

firrae commented Oct 10, 2016

@SachaG I'm sure it won't, but I do feel like MDG needs something for Angular and React that offer the same level of quick prototyping without the need of Blaze.

@timbrandin
Copy link
Member

Who needs access? I really have no proffessional time for this at work atm,
just my hobby time which is really limited.

Cheers,
// T

2016-10-11 1:40 GMT+02:00 Steve Lambe notifications@github.com:

@SachaG https://github.com/SachaG I'm sure it won't, but I do feel like
MDG needs something for Angular and React that offer the same level of
quick prototyping without the need of Blaze.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABouelGVJ-9Ixn5Xd7WvENfSoJ4YrJVSks5qysz_gaJpZM4JEgwG
.

Cheers,
// Tim Brandin @timbrandin https://twitter.com/#!/timbrandin
http://timbrandin.com
http://studiointeract.com

@SachaG
Copy link
Collaborator

SachaG commented Oct 18, 2016

Put me down for access, I'll do my best to pitch in when I can.

@timbrandin
Copy link
Member

Cool! // T

2016-10-18 2:30 GMT+02:00 Sacha Greif notifications@github.com:

Put me down for access, I'll do my best to pitch in when I can.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABouer58_X0mMxf3igOcdeH34mFrU16dks5q1BMpgaJpZM4JEgwG
.

Cheers,
// Tim Brandin @timbrandin https://twitter.com/#!/timbrandin
http://timbrandin.com
http://studiointeract.com

@timbrandin
Copy link
Member

You're added. // T

2016-10-18 13:14 GMT+02:00 Tim Brandin tim.brandin@gmail.com:

Cool! // T

2016-10-18 2:30 GMT+02:00 Sacha Greif notifications@github.com:

Put me down for access, I'll do my best to pitch in when I can.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABouer58_X0mMxf3igOcdeH34mFrU16dks5q1BMpgaJpZM4JEgwG
.

Cheers,
// Tim Brandin @timbrandin https://twitter.com/#!/timbrandin
http://timbrandin.com
http://studiointeract.com

Cheers,
// Tim Brandin @timbrandin https://twitter.com/#!/timbrandin
http://timbrandin.com
http://studiointeract.com

@PolGuixe
Copy link
Collaborator

I would also like to have access. I Don't have too much bandwith but I planning to use it in production, hence it would to help to maintain it.

@timbrandin
Copy link
Member

Absolutely, you're in the team now.

Yeah, I have some big apps planned too, still really busy with Blaze apps.
It's hard to force a full transition, it takes time I guess.

2016-10-19 12:34 GMT+02:00 PolGuixe notifications@github.com:

I would also like to have access. I Don't have too much bandwith but I
planning to use it in production, hence it would to help to maintain it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABouetmrPwEFbOYYkf1QnyCA2qmietzCks5q1fIcgaJpZM4JEgwG
.

Cheers,
// Tim Brandin @timbrandin https://twitter.com/#!/timbrandin
http://timbrandin.com
http://studiointeract.com

@PolGuixe
Copy link
Collaborator

PolGuixe commented Oct 21, 2016

Edit:
@timbrandin can I accepts PRs now? -- Ok, I see now ;)

@JeremyIglehart
Copy link

I too would like to have access. I'm using this package in production on my main client's web app. So, I would love to help pitch in when I have a moment to help maintain this great package.

@SachaG
Copy link
Collaborator

SachaG commented Oct 24, 2016

Now that multiple people have access to the repo, let's make sure we still use PRs, branches, etc. and coordinate our work. You guys are welcome to join the Telescope Slack, I could open an accounts-ui channel in there?

@PolGuixe
Copy link
Collaborator

@SachaG the slack channel would be nice to coordinate.

@timbrandin
Copy link
Member

Yes

21 okt. 2016 kl. 11:37 skrev PolGuixe notifications@github.com:

@timbrandin can I accepts PRs now?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@stolinski
Copy link

I'd be down to join that.

![](https://link.nylas.com/open/btn3jrt0e1c1mt7ifq38plxs/local-1d7e5945-f978?r
=cmVwbHkrMDAwYTM2Yzc1MDEwZDI2NmIyMWRhY2E3YjBmY2Y5NTFlOTUwZGVhOWFkNzFkY2VmOTJjZ
jAwMDAwMDAxMTQyNTNhOWY5MmExNjljZTA5YzIwMWMwQHJlcGx5LmdpdGh1Yi5jb20=)

On Oct 23 2016, at 8:57 pm, Sacha Greif notifications@github.com wrote:

Now that multiple people have access to the repo, let's make sure we still
use PRs, branches, etc. and coordinate our work. You guys are welcome to join
the [Telescope Slack](http://slack.telescopeapp.org&r=cmVwbHkrMDAwYTM2Yzc1MDEw
ZDI2NmIyMWRhY2E3YjBmY2Y5NTFlOTUwZGVhOWFkNzFkY2VmOTJjZjAwMDAwMDAxMTQyNTNhOWY5Mm
ExNjljZTA5YzIwMWMwQHJlcGx5LmdpdGh1Yi5jb20=), I could open an accounts-ui
channel in there?


You are receiving this because you commented.
Reply to this email directly, [view it on
GitHub](#60 (comment)
55637768&r=cmVwbHkrMDAwYTM2Yzc1MDEwZDI2NmIyMWRhY2E3YjBmY2Y5NTFlOTUwZGVhOWFkNzF
kY2VmOTJjZjAwMDAwMDAxMTQyNTNhOWY5MmExNjljZTA5YzIwMWMwQHJlcGx5LmdpdGh1Yi5jb20=)
, or [mute the thread](https://github.com/notifications/unsubscribe-auth
/AAo2x4n-bHsbO7_MvLDdCeqUJoQMBa2Yks5q3B6fgaJpZM4JEgwG&r=cmVwbHkrMDAwYTM2Yzc1MD
EwZDI2NmIyMWRhY2E3YjBmY2Y5NTFlOTUwZGVhOWFkNzFkY2VmOTJjZjAwMDAwMDAxMTQyNTNhOWY5
MmExNjljZTA5YzIwMWMwQHJlcGx5LmdpdGh1Yi5jb20=).![](https://github.com/notificat
ions/beacon/AAo2x-g8HIDUc4BuAIopdFHVZE9rG0Ynks5q3B6fgaJpZM4JEgwG.gif)

@firrae
Copy link

firrae commented Oct 25, 2016

@stolinski I don't think your email reply came in formatted properly?

@CSMR-DB
Copy link

CSMR-DB commented Jan 10, 2017

Is there an official release including the fix or some fork I might need to include with a Meteor project I'm currently building? Currently I'm forced to run universe:accounts-ui which does not (yet?) support configuration while the last release dates from October last year as far as I can tell. The other option would be using okgrow:accounts-ui-react which runs into the issue 'composeWithTracker' is not a function. That's an issue they're working on but I haven't been able to test their package and I'd like to run the std:accounts-ui as it's the biggest package on Atmosphere and I would love to use their config. At this point I'm even considering going full DIY with a registration from scratch using the Meteor documentation but then time would be the limiting factor. I know this issue is closed but the latest package still gives me the issue mentioned in the OP.

@dschreij
Copy link

I'm getting this error #92 which seems related to this fix. Apparently, in my case this.input doesn't even exist yet, even though I have added fields according to the instructions in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests