Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KeyboardInterrupt handling. #466

Closed
andreidenissov-cog opened this issue Mar 26, 2021 · 0 comments · Fixed by #467
Closed

Improve KeyboardInterrupt handling. #466

andreidenissov-cog opened this issue Mar 26, 2021 · 0 comments · Fixed by #467

Comments

@andreidenissov-cog
Copy link
Contributor

In many cases throughout the code, we catch and handle BaseException in some manner.
Problem is, KeyboardInterrupt is a BaseException and so, it's handling somewhere along
a call stack effectively disables Ctrl-C during console application execution.
We need to make sure that KeyboardInterrupt always propagates to the top of call stack
to be handled by Python runtime and terminates execution fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant