Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Add WordPress profile area #198

Closed
wants to merge 2 commits into from
Closed

Conversation

marksabbath
Copy link
Collaborator

@marksabbath marksabbath commented Aug 6, 2019

Summary of change:
This PR brings the WordPress profile into AB block-author-profile.

This PR has been:

  • Linted for syntax errors
  • Tested against the WordPress coding standards
  • Tested with the bundled test suite(s)

How to test:

  • Download the branch;
  • Add a new block-author-profile;
  • Add any value to WordPress URL;
  • The WordPress icon as a link should show.

Closes #201

Suggested Changelog Entry:

  • Add WordPress Profile URL section on block-author-profile

Copy link
Member

@mindctrl mindctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works fine. The only potentially "weird" thing to me is the label. "WordPress URL"... mainly because WordPress is software. But that's just a minor quibble. We're referring to wordpress.org profile here, right @marksabbath? Any thoughts @mikemcalister?

@marksabbath
Copy link
Collaborator Author

This looks good to me and works fine. The only potentially "weird" thing to me is the label. "WordPress URL"... mainly because WordPress is software. But that's just a minor quibble. We're referring to wordpress.org profile here, right @marksabbath? Any thoughts @mikemcalister?

Yeap, exactly @mindctrl we could add a description as we have in the email field making in clear. Something like:

"Use here your wordpress.org profile."

@mikemcalister
Copy link
Contributor

What about "WordPress Profile URL"? Great addition here, @marksabbath!

@marksabbath
Copy link
Collaborator Author

marksabbath commented Aug 8, 2019

What about "WordPress Profile URL"? Great addition here, @marksabbath!

Definitely works for me. Should we use that as Title or description @mikemcalister ?

@mindctrl
Copy link
Member

mindctrl commented Aug 8, 2019

Sounds good, thanks @marksabbath!

@mindctrl
Copy link
Member

mindctrl commented Aug 9, 2019

Merged here: 916f875

Thanks @marksabbath!

@mindctrl mindctrl closed this Aug 9, 2019
@mindctrl mindctrl deleted the add/wordpress-profile branch August 9, 2019 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants