Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: get_root_files called with remote_dir and root_dir swapped in orphaned module #333

Closed
vaskozl opened this issue Jun 13, 2023 · 0 comments · Fixed by #344
Closed
Assignees
Labels
bug Something isn't working status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@vaskozl
Copy link

vaskozl commented Jun 13, 2023

Describe the Bug

After investigating why orphaned files weren't being removed I discovered that util.get_root_files gets called in reverse:

remove_orphaned.py:

root_files = self.executor.submit(util.get_root_files, self.remote_dir, self.root_dir, self.orphaned_dir)

util.py

def get_root_files(root_dir, remote_dir, exclude_dir=None):

This results in files not being removed as the wrong dir is searched.

Config

root_dir: /torrents
remote_dir: /data/torrents

Installation

Docker

Version Number

4.0.0

What branch are you on?

master

@vaskozl vaskozl added the bug Something isn't working label Jun 13, 2023
vaskozl added a commit to vaskozl/qbit_manage that referenced this issue Jun 13, 2023
bobokun added a commit that referenced this issue Jun 19, 2023
@bobokun bobokun added the status:added-to-develop Feature Request or Bug Fix is in Develop label Jun 19, 2023
@bobokun bobokun mentioned this issue Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants