Merge pull request tidymodels#1277 from tidymodels/get-back-to-dev

stufield · Dec 14, 2023 · 36a1307 · 36a1307
2 parents 7fd3e90 + 9960bbf
commit 36a1307
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 15 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -52,7 +52,7 @@ Suggests:
     kernlab,
     knitr,
     modeldata (>= 0.1.1),
-    parsnip (>= 0.1.7),
+    parsnip (>= 1.1.1.9001),
     RANN,
     RcppRoll,
     rmarkdown,
@@ -72,3 +72,5 @@ Config/testthat/edition: 3
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.2.3
+Remotes:
+    tidymodels/parsnip
diff --git a/R/dummy.R b/R/dummy.R
@@ -224,7 +224,7 @@ warn_new_levels <- function(dat, lvl, details = NULL) {
   if (length(ind) > 0) {
     lvl2 <- unique(dat[ind])
     cli::cli_warn(c(
-      "!" = "There are new levels in a factor: {lvl2}",
+      "!" = "There are new levels in a factor: {.var {lvl2}}.",
       details
     ))
   }

diff --git a/R/recipe.R b/R/recipe.R
@@ -282,7 +282,8 @@ inline_check <- function(x) {
           found: {.and {.code {funs}}}.",
       i = "Use steps to do transformations instead.",
       i = "If your modeling engine uses special terms in formulas, pass \\
-          that formula to workflows as a model formula."
+          that formula to workflows as a \\
+          {.help [model formula](parsnip::model_formula)}."
     ))
   }
 

diff --git a/tests/testthat/_snaps/basics.md b/tests/testthat/_snaps/basics.md
@@ -7,7 +7,7 @@
       x No in-line functions should be used here.
       i The following function was found: `log`.
       i Use steps to do transformations instead.
-      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula.
+      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula (`?parsnip::model_formula()`).
 
 ---
 
@@ -18,7 +18,7 @@
       x No in-line functions should be used here.
       i The following functions were found: `^` and `(`.
       i Use steps to do transformations instead.
-      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula.
+      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula (`?parsnip::model_formula()`).
 
 ---
 
@@ -29,7 +29,7 @@
       x No in-line functions should be used here.
       i The following function was found: `:`.
       i Use steps to do transformations instead.
-      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula.
+      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula (`?parsnip::model_formula()`).
 
 ---
 
@@ -40,7 +40,7 @@
       x No in-line functions should be used here.
       i The following function was found: `^`.
       i Use steps to do transformations instead.
-      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula.
+      i If your modeling engine uses special terms in formulas, pass that formula to workflows as a model formula (`?parsnip::model_formula()`).
 
 # Using prepare
 

diff --git a/tests/testthat/_snaps/dummy.md b/tests/testthat/_snaps/dummy.md
@@ -25,47 +25,47 @@
       factors <- prep(factors, training = sacr_missing)
     Condition
       Warning:
-      ! There are new levels in a factor: NA
+      ! There are new levels in a factor: `NA`.
 
 ---
 
     Code
       factors_data_1 <- bake(factors, new_data = sacr_missing)
     Condition
       Warning:
-      ! There are new levels in a factor: NA
+      ! There are new levels in a factor: `NA`.
 
 # tests for NA values in ordered factor
 
     Code
       factors <- prep(factors, training = sacr_ordered)
     Condition
       Warning:
-      ! There are new levels in a factor: NA
+      ! There are new levels in a factor: `NA`.
 
 ---
 
     Code
       factors_data_1 <- bake(factors, new_data = sacr_ordered)
     Condition
       Warning:
-      ! There are new levels in a factor: NA
+      ! There are new levels in a factor: `NA`.
 
 # new levels
 
     Code
       recipes:::warn_new_levels(testing$x1, levels(training$x1))
     Condition
       Warning:
-      ! There are new levels in a factor: C
+      ! There are new levels in a factor: `C`.
 
 ---
 
     Code
       bake(rec, new_data = testing)
     Condition
       Warning:
-      ! There are new levels in a factor: C
+      ! There are new levels in a factor: `C`.
     Output
       # A tibble: 10 x 2
          y      x1_B

diff --git a/tests/testthat/_snaps/unknown.md b/tests/testthat/_snaps/unknown.md
@@ -4,11 +4,11 @@
       te_1 <- bake(rec_1, sacr_te)
     Condition
       Warning:
-      ! There are new levels in a factor: WEST_SACRAMENTO
+      ! There are new levels in a factor: `WEST_SACRAMENTO`.
       * New levels will be coerced to `NA` by `step_unknown()`.
       i Consider using ?step_novel (`?recipes::step_novel()`) before `step_unknown()`.
       Warning:
-      ! There are new levels in a factor: z95691
+      ! There are new levels in a factor: `z95691`.
       * New levels will be coerced to `NA` by `step_unknown()`.
       i Consider using ?step_novel (`?recipes::step_novel()`) before `step_unknown()`.