Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cactus armor and admin armor #14

Closed
wants to merge 1 commit into from

Conversation

crazyginger72
Copy link
Contributor

admin armor has the option of being enabled vie the .conf with enable_admin_armor = true
also have enhanced wood and cactus shields!

@donat-b
Copy link
Contributor

donat-b commented Nov 10, 2014

Why is it purple? xD

@crazyginger72
Copy link
Contributor Author

the admin pick from maptools was the first admin tool and its magenta/pink, i do make all the admin tools the same colour to match lol i have ocd!!! but it can be changed if anyone likes :)

@stujones11
Copy link
Owner

@crazyginger72 Thank you for your contribution, for the most part I like it and would be glad to merge the cactus and admin armor. There would, however, need to be some changes in configuration to keep it consistent with other armor configs using armor.conf

Also I do not think the swords are a necessary inclusion since there are other mods that add very similar items and this is really meant to be an armor mod, not a weapons mod.

If you are unable (or unwilling) to make the required changes to this PR then I will do so myself when I have time to test everything.

@crazyginger72
Copy link
Contributor Author

I have removed the swords but am not 100% sure what you mean about the .conf

@stujones11
Copy link
Owner

@crazyginger72 Don't worry about it, just make the admin armor available to all but without crafts.
It would also be preferable if you put the admin armor registration in init.lua with everything else rather than another included file.

I will make admin armor optional at a later date if there proves to be a demand for that.

@crazyginger72
Copy link
Contributor Author

ok i think this is what you want :)

@stujones11
Copy link
Owner

I have merged your request but had to make a few changes here and there, hope you don't mind.

Cheers!

@stujones11 stujones11 closed this Jan 9, 2015
@crazyginger72
Copy link
Contributor Author

Thanks, i have had that on my servers for a while but deezl wanted it for his carbone so i decided to pull request it :)

Thomas--S pushed a commit to Thomas--S/minetest-3d_armor that referenced this pull request Oct 11, 2020
* Added the possibility to hide wielded items in-game
* Update wieldview/README.txt

Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants