Fix TSTP trap #13
Merged
Fix TSTP trap #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2019
* Tests use normal fork and communicate with test runner via IO.pipe. * Tests uses a zero interval to exit ASAP without timeout when done. * Children need to `exit!` to avoid running test/unit at_exit hooks. * Gemspec depends on a specific minor version of resque. We must depend on ~> v1.26.0, because these methods are considered internal, are not a stable API, and can change with every version. I.e. as written, the tests do not pass with v1.25.0 nor with v1.27.0. Until Resque::Worker has a stable API we can target, this gem will need to be tested with each minor release.
There's a lot of unhelpful noise that comes from running `ruby -w`: https://mislav.net/2011/06/ruby-verbose-mode/
In tests, `SIGTSTP` is often ignored for ruby 2.3-2.5 (usually works in 2.6?). I assume this has something to do with some signals temporarily being blocked by ruby, but I'm really not sure. However, in my tests, `SIGQUIT` always gets through to the handler. Since `SIGQUIT` is normally registered to call `shutdown` anyway, I've simply re-registered it to continue that role in the `term_child` environment.
This fixes an issue when shutdown order is sent while the first job is still running. Also added tests for each of the three common shutdown styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #11, and also fixes #10.
compare for just this: nevans/resque-multi-job-forks@fix-tests-resque-v1.26.0...fix-tstp-trap