Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF-to-ZIP conversion #156

Open
aaronleopold opened this issue Sep 9, 2023 · 2 comments
Open

PDF-to-ZIP conversion #156

aaronleopold opened this issue Sep 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@aaronleopold
Copy link
Collaborator

I think it could be useful to support converting PDF files to archives of images. Fairly low effort to support this once #35 is officially merged.

@aaronleopold aaronleopold added the enhancement New feature or request label Sep 9, 2023
@DieselTech
Copy link

It certainly can be useful, but it's not as straight forward on paper. Depending on the library used and the complexity of the PDF, the conversion to images can miss layers that are more complex. PDF has a lot of nuances that can cause edges cases.

@aaronleopold
Copy link
Collaborator Author

aaronleopold commented Sep 9, 2023

Good point(s). Honestly I’m not too familiar with how reliable PDF-page-to-image converting is using Pdfium, but also in general, since I generally avoid collecting PDFs myself for these very reasons. That library is pretty much the only viable option for Rust I could find, though. Hopefully for scenarios I’d imagine this feature would be used (e.g. comic books, as opposed to more complicated PDF files with text or forms), it won’t present with too many issues.

aaronleopold added a commit that referenced this issue Sep 19, 2023
* start barebones PDF support, update some docs

* PDF rendering and streaming support

* support PDF-to-ZIP conversions in core (#156)

* remove duplicate logic

* download pdfium in Dockerfile

* oops

* oopsies
aaronleopold added a commit that referenced this issue Sep 23, 2023
* New translations en.json (Portuguese)

* 📝 Update README and CONTRIBUTING

* 🐛 fix autoclosing drawer (#157)

* ✨ basic PDF support (#158)

* start barebones PDF support, update some docs

* PDF rendering and streaming support

* support PDF-to-ZIP conversions in core (#156)

* remove duplicate logic

* download pdfium in Dockerfile

* oops

* oopsies

* 🐛 Fix entrypoint.sh adduser and addgroup commands (#160)

* New translations en.json (German)

* New translations en.json (German)

* New translations en.json (Dutch)

* 🎨 support regenerate thumbnails from UI and improve mobile friendliness (#161)

* New translations en.json (Romanian)

* New translations en.json (French)

* New translations en.json (Spanish)

* New translations en.json (Afrikaans)

* New translations en.json (Arabic)

* New translations en.json (Catalan)

* New translations en.json (Czech)

* New translations en.json (Danish)

* New translations en.json (German)

* New translations en.json (Greek)

* New translations en.json (Finnish)

* New translations en.json (Hebrew)

* New translations en.json (Hungarian)

* New translations en.json (Italian)

* New translations en.json (Japanese)

* New translations en.json (Korean)

* New translations en.json (Dutch)

* New translations en.json (Norwegian)

* New translations en.json (Polish)

* New translations en.json (Russian)

* New translations en.json (Serbian (Cyrillic))

* New translations en.json (Swedish)

* New translations en.json (Turkish)

* New translations en.json (Ukrainian)

* New translations en.json (Chinese Simplified)

* New translations en.json (English)

* New translations en.json (Vietnamese)

* New translations en.json (Portuguese, Brazilian)

* New translations en.json (Portuguese)

* New translations en.json (French)

* make all available languages selectable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants