Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Search entire EPUB text and vertical scroll reader #278

Merged
merged 7 commits into from Feb 24, 2024

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Feb 20, 2024

Resolves #269
Resolves #276

PR adds two new features, and fixes a few bugs introduced from the hide libraries feature:

  • You can now search the entire content of an ebook with the built-in reader
  • I added a new vertical scroll reader
    • The library I chose, while it was easily the least headache of some of the other virtualization options I have tried, doesn't support horizontal lists yet. I'll try to see what effort adding that would be. You can see the context here: Feature request: horizontal list petyosi/react-virtuoso#62
  • Hot fixed restriction filters swallowing relational filters, which in plainer words resulted in the wrong items being shown in the wrong libraries when adding filters on a relation from the client to the server

I have to add a basic toolbar to the vertical reader, and I'd like to try and clean up the fix to be a bit more efficient in terms of the resulting query, but this is mostly good to go

@aaronleopold aaronleopold marked this pull request as ready for review February 24, 2024 00:47
@aaronleopold aaronleopold merged commit 3108cb7 into experimental Feb 24, 2024
3 checks passed
@aaronleopold aaronleopold deleted the al/scroll-reader-and-epub-search branch February 24, 2024 01:18
@aaronleopold aaronleopold mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant