✨ Hide libraries from target user(s) #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronleopold
added a commit
that referenced
this pull request
Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the ability to hide libraries from specific users on the server. There are also some bug fixes introduced from the previous scanner rewrite, and UI refreshes to try and bring all of the related pages together in a cohesive and less disconnected manner (i.e. unify them with some shared navigation).
The permissions might seem odd at a glance, but I've built it so that if you want to exclude users from a library you need to have the
users:readpermission, which allows you to query for all users on the server. Otherwise, if you have the permission to create and manage a library, but not the permission to query for users, the functionality will be hidden.