Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix opening RAR files with unicode characters #253

Merged
merged 6 commits into from Feb 2, 2024
Merged

馃悰 Fix opening RAR files with unicode characters #253

merged 6 commits into from Feb 2, 2024

Conversation

aaronleopold
Copy link
Collaborator

PR fixes an issue that caused unrar to error when encountering unicode characters in the file name

  • Pull in libc as Linux-only dep
  • Explicitly set the locale before interacting with RAR files (when OS is Linux)

@aaronleopold aaronleopold marked this pull request as ready for review January 31, 2024 00:23
@aaronleopold aaronleopold merged commit cfa0101 into develop Feb 2, 2024
7 checks passed
@aaronleopold aaronleopold deleted the al/unrar-locale branch February 2, 2024 00:44
@aaronleopold aaronleopold mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aaronleopold