Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨API and DB definition for notifier feature #264

Merged
merged 10 commits into from Feb 10, 2024
Merged

Conversation

LRotenberger
Copy link
Collaborator

Implemented back-end for notification features + defined user permissions:

  • Defined prisma model for Notifier and corresponding config
  • Current supported platforms: Discord and Telegram
  • Added swagger-ui types via utoipa
  • Implemented associated permissions

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

I had one comment but that can be tackled later once these features are closer to being exposed through the UI

webhook_url: String,
},
Telegram {
encrypted_token: String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are storing an encrypted token for Telegram, we'll have to accepted an unencrypted token value during the creation flow. No UI exists yet, so this can be a follow up 🙂

/// Return a list of permissions, if any, which are inherited by self
///
/// For example, UserPermission::CreateNotifier implies UserPermission::ReadNotifier
pub fn associated(&self) -> Vec<UserPermission> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@aaronleopold aaronleopold merged commit 9280e7f into develop Feb 10, 2024
7 checks passed
@aaronleopold aaronleopold deleted the lr/integrations branch February 10, 2024 00:50
This was referenced Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants