New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨API and DB definition for notifier feature #264
Conversation
Co-authored-by: Aaron Leopold <aaronleopold@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
I had one comment but that can be tackled later once these features are closer to being exposed through the UI
webhook_url: String, | ||
}, | ||
Telegram { | ||
encrypted_token: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are storing an encrypted token for Telegram, we'll have to accepted an unencrypted token value during the creation flow. No UI exists yet, so this can be a follow up 🙂
/// Return a list of permissions, if any, which are inherited by self | ||
/// | ||
/// For example, UserPermission::CreateNotifier implies UserPermission::ReadNotifier | ||
pub fn associated(&self) -> Vec<UserPermission> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Implemented back-end for notification features + defined user permissions: