Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Simplify dockerfile #268

Merged
merged 1 commit into from Feb 14, 2024
Merged

🎨 Simplify dockerfile #268

merged 1 commit into from Feb 14, 2024

Conversation

JMicheli
Copy link
Contributor

This pull request removes some cruft from the Dockerfile, it does this by:

  • Combining layers that need not be separate, such as ENV and RUN layers.
  • Removing WORKDIR / lines - as the workdir is / by default.

@JMicheli
Simplify dockerfile:
745caad 
* Combine layers that don't need to be separate.
* Remove default workdir settings.
@aaronleopold aaronleopold changed the base branch from main to develop February 13, 2024 14:28
aaronleopold
aaronleopold approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! I'll let CI run and will try to get it merged in after work

@aaronleopold aaronleopold changed the title Simplify dockerfile 🎨 Simplify dockerfile Feb 13, 2024
@aaronleopold aaronleopold merged commit 3ef7a24 into stumpapp:develop Feb 14, 2024
5 checks passed
This was referenced Feb 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronleopold aaronleopold aaronleopold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JMicheli @aaronleopold