Update GHA CI build #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rust part needs some TLC, but that's mostly because of the dependencies I think. Overall, this looks good to me, it provides a good foundation. Thanks again! |
|
Great! You're very welcome; happy Hacktober! |
Closed
aaronleopold
pushed a commit
that referenced
this pull request
Oct 22, 2022
* Update GHA CI build * Update job for current directory structure
aaronleopold
added a commit
that referenced
this pull request
Oct 29, 2022
Update GHA CI build (#72)
aaronleopold
added a commit
that referenced
this pull request
Oct 30, 2022
* Update GHA CI build (#72) * Update GHA CI build * Update job for current directory structure * reorg: prelude * dx, factory pattern, ci * bump prisma * wip: dao * oop * oop? Co-authored-by: Matt Boulanger <Celeo@users.noreply.github.com>
f8thl3ss
pushed a commit
to f8thl3ss/stump
that referenced
this pull request
Nov 9, 2022
* Update GHA CI build * Update job for current directory structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the existing build on push. The two jobs (one each for the Rust and TypeScript code) run in parallel, and both make use of caching to speed up their runs, as requested.
I explicitly use the TS type check commands in the two directories I see
tsconfig.jsonfiles rather than runningpnpm run checksat the top level, as that'd require the Rust setup in both jobs. That'd work, but I'd recommend collapsing the two jobs into one and forgoing the concurrency in favor of command simplicity.Fixes #68
re: #71