[swm-gaps] gaps should not be applied to modeline

[jamesmccabe]

When I turn on swm-gaps it moves my modeline and adds gaps to it.
I presume this should not be the default behavior and maybe it was only tested using Polybar instead of the Stump modeline?

Screenshot:

Here is my .stumpwmrc.

Removing defun add-outer-gaps function seems to fix the problem but the outergaps feature is lost.

[npavlinek]

I'm not the author of this module, but maybe this was intended? Although looking at the screenshot of the module, maybe not.

Perhaps there should be an option whether a user wants to apply gaps to the modeline or not. Thoughts?

[lepisma]

I am the author (for the outer gaps thing). I used polybar so didn't face this issue. I agree about having an option for applying gaps to modeline.

I think it might need some refactoring since the outer gaps were implemented by resizing the whole head. Allowing modeline might mean changing this.

[lepisma]

Another way might be to make the modeline aware of gaps and have it position itself correctly. Though I am not sure which way is going to be easier/better. Thoughts?

[jamesmccabe]

Thanks for the replies. My Lisp skills are poor so I don't know how easy it would be to implement the features. My guess is not very easy 😁. If we could just make the modeline stay in default position I would be happy with that.

Having the option to apply gaps to the modeline or turning it off would be cool though.
Applying gaps to the modeline could be another module maybe with separate code? I'm not sure if that would work either.

[lepisma]

I will give it a shot this weekend.

[lepisma]

I have a possible fix in here. There are now three kind of gaps defined by the following variables:

1. *head-gaps-size*. This is what borders the monitor. Everything (including modeline) comes inside its boundary. You would want to set it to 0.
2. *outer-gaps-size* mimicks the behaviour of the older variable with same name but adds asymmetric gaps around individual windows after checking if they are facing monitor edges.
3. *inner-gaps-size* is the same old thing.

Here is a quick picture to describe these.

The outermost gaps are due to *head-gaps-size*. The innermost (around all edges of window) are due to *inner-gaps-size* and the extra gaps for the monitor facing edges is from *outer-gaps-size*.

Try the fork and see if it behaves correctly. If all looks fine, then I will create a PR here.

[jamesmccabe]

Thanks Abhinav it seems to work fine. I am getting an error message though which doesn't effect the functionality though. It only appears when the gaps are toggled on.

Error in Command 'toggle-gaps': The function STUMPWM:ONLY-TILE-WINDOWS is undefined.

Maybe I am doing something wrong?

[npavlinek]

I just tried it myself. Seems to work fine. @lepisma

How are you getting that error? @jamesmccabe (I tried the same config with the binding as you and get no error)

[lepisma]

Which version of stumpwm are you using @jamesmccabe? (although the missing function is around a year old so don't know if this matters).

[jamesmccabe]

Sorry I am using stumpwm version 1.0.0 so I think this is the problem. I will test the git version later.

[lepisma]

Right, I now realize that v1 doesn't have that fn. Since, v1 is latest stable release, should I revert the change that I made (lepisma@08918d7)? I think addon modules should at least work with the latest stable.

[lepisma]

Or I can also take this opportunity to ask @dbjergaard if v1.0.1-rc can go as a stable release? I feel there are sufficient amount of really useful changes in the rc. Its also been working without any hiccups for me at least. How are others feeling about it?

[npavlinek]

Maybe you should have a look at this: stumpwm/stumpwm#454, @lepisma.