You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tested with TabGroupsManager, which adds an extra tab groups bar above the tabs bar. Result:
appcontent.parentNode.insertBefore(tabsToolbar, appcontent) which should be left of the screen, is actually right of the screen.
Solution
The node that the tab bar is placed before/after, needs to be specified in a way thats less likely to be affected by other extensions adding toolbars.
The text was updated successfully, but these errors were encountered:
stilez
changed the title
"Tab bar location: left" places it to the right
"Tab bar location: left" places it to the right with some other tab extensions
Feb 18, 2020
stilez
changed the title
"Tab bar location: left" places it to the right with some other tab extensions
Doesnt play well with some other extensions, relies on inappropriate DOM node to place tab bar left/right
Feb 18, 2020
Hi @stilez , thank you for bringing this issue to my attention. I suspect that this is the cause of a couple of issues that are linked to this issue. When I have time I would like to refactor the original TU code (since that's what I inherited). I should be able to tackle this issue once I am able to begin doing that.
Would you be available for questions I may have once I being my work? If so, how may I reach you?
Other extensions modify or add toolbars. Then the incorrect parent node is selected in tabutils-vt.js for left/right/bottom location.
CODE LOCATION: tabutils-vt.js last part, switch statement:
switch (TU_getPref("extensions.tabutils.tabBarPosition"))
Tested with
TabGroupsManager
, which adds an extra tab groups bar above the tabs bar. Result:appcontent.parentNode.insertBefore(tabsToolbar, appcontent)
which should be left of the screen, is actually right of the screen.Solution
The node that the tab bar is placed before/after, needs to be specified in a way thats less likely to be affected by other extensions adding toolbars.
The text was updated successfully, but these errors were encountered: