Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesnt play well with some other extensions, relies on inappropriate DOM node to place tab bar left/right #7

Open
stilez opened this issue Feb 18, 2020 · 3 comments
Assignees

Comments

@stilez
Copy link

stilez commented Feb 18, 2020

Other extensions modify or add toolbars. Then the incorrect parent node is selected in tabutils-vt.js for left/right/bottom location.

CODE LOCATION: tabutils-vt.js last part, switch statement:

  • switch (TU_getPref("extensions.tabutils.tabBarPosition"))

Tested with TabGroupsManager, which adds an extra tab groups bar above the tabs bar. Result:

  • appcontent.parentNode.insertBefore(tabsToolbar, appcontent) which should be left of the screen, is actually right of the screen.

Solution

The node that the tab bar is placed before/after, needs to be specified in a way thats less likely to be affected by other extensions adding toolbars.

@stilez stilez changed the title "Tab bar location: left" places it to the right "Tab bar location: left" places it to the right with some other tab extensions Feb 18, 2020
@stilez stilez changed the title "Tab bar location: left" places it to the right with some other tab extensions Doesnt play well with some other extensions, relies on inappropriate DOM node to place tab bar left/right Feb 18, 2020
@stux2000 stux2000 self-assigned this Jul 6, 2020
@stux2000
Copy link
Owner

stux2000 commented Jul 6, 2020

Hi @stilez , thank you for bringing this issue to my attention. I suspect that this is the cause of a couple of issues that are linked to this issue. When I have time I would like to refactor the original TU code (since that's what I inherited). I should be able to tackle this issue once I am able to begin doing that.

Would you be available for questions I may have once I being my work? If so, how may I reach you?

Thanks,

-stux

@stilez
Copy link
Author

stilez commented Jul 6, 2020

@stux2000

Would you be available for questions I may have once I being my work? If so, how may I reach you?

Sure!

Here is fine, I seem to get notifications with the "@". If you need me more directly, stilezy ( note the "y") at g and then mail.

D. com, of course.

@stilez
Copy link
Author

stilez commented Jul 6, 2020

If it helps, my use is:

  • left side tab bar
  • with multiple tab select, drag/drop, and URL copy
  • working with TabGroupsManager (revived or otherwise)
  • and using ctrl-tab for most recent used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants