Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Preview Does not behave properly when new "browser.tabs.insertAllAfterCurrent" setting is set to true #8

Open
stux2000 opened this issue Jul 6, 2020 · 2 comments
Assignees

Comments

@stux2000
Copy link
Owner

stux2000 commented Jul 6, 2020

As reported on IRC:

The following commit in PM unstable introduces a new feature "browser.tabs.insertAllAfterCurrent":

If this feature is enabled and the "Print Preview" feature is used, after closing the preview a different tab from what was previewed is shown. This may be caused by clashes in how PM and TU handle tab creation.

Also during testing on current PM stable (28.10.0) when using the tabs on Left or Right feature, the print preview keeps showing the tabs and also returns to a different tab.

@stux2000
Copy link
Owner Author

stux2000 commented Jul 6, 2020

After reviewing the issues I suspect that issue #7 is part of the cause of this issue.

@stux2000
Copy link
Owner Author

stux2000 commented Sep 1, 2020

comment from IRC:
Tab Mix Plus has a special setting for closing a tab, focus: Opener/right tab
with that instead of just Right Tab print preview reverts to the opener, in that case the printed site

It seems that the above setting could work around the issue. The "Tab Closing" settings may provide an appropriate workaround as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant