Feature/temp image upload #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d6cfed6.
| export const MediumDialog: React.FC<IProps> = ({ open, onClose, initialData, isFeatured }) => { | ||
| const styles = useStyles(); | ||
|
|
||
| const [title, setTitle] = React.useState(initialData?.title ?? ""); |
There was a problem hiding this comment.
Okay...so this is where I'd use a useReducer as your state is pretty complicated.
There was a problem hiding this comment.
I don't think that would be a benefit though. If TS had Rust/Haskell style sum types I'd go for it, but this is simpler than a reducer imo
| isFeatured: boolean | ||
| } | ||
|
|
||
| export const MediumDialog: React.FC<IProps> = ({ open, onClose, initialData, isFeatured }) => { |
There was a problem hiding this comment.
This component feels a little complicated. Plus is it a MediumDialog if it also includes a form?
There was a problem hiding this comment.
It is complicated, but not sure how I'd make it better. It's all one problem. I'd say it is a dialog as although the meat is a form, it's displayed as a dialog, and that's consistent with my naming scheme in the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather bloated PR adds support for media upload to the stuyspec website. This is done via an extension of the article-extension model: now, each article extension can have an optional media field in addition to props, which stores a json-encoded array of medium ids the component will render. Within the CMS, a Medium upload dialog can create a medium, which will then be attached to the article on upload or edit.
TODO: media that are subsequently removed from the article are still attached to the article type on uploading. Currently not an important issue but needs fixing.