Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light theme is kind of lackluster #125

Closed
randysim opened this issue Jul 3, 2024 · 12 comments
Closed

light theme is kind of lackluster #125

randysim opened this issue Jul 3, 2024 · 12 comments
Labels
enhancement New feature or request

Comments

@randysim
Copy link
Collaborator

randysim commented Jul 3, 2024

outlines become very faint and everything just looks white.

hard to use the site in bright theme.

though this isn't really the biggest issue because who uses light theme anyways?

@randysim randysim added the enhancement New feature or request label Jul 3, 2024
@SnowyNate
Copy link
Contributor

I always use the light theme for this site. We could fix this by using a gradient color as the background.

@SnowyNate
Copy link
Contributor

It turns out this is much more tedious than I thought. We would have to switch from ThemeProvider to CSS, which from my research actually improves performance. Thoughts? @randysim @Rahuldeb5 @TheEgghead27

@randysim
Copy link
Collaborator Author

randysim commented Jul 4, 2024

Ideally the site would have a minimal, sleek design, which I think having the ENTIRE background be a gradient goes against.

The problem with light theme is the lack of contrast between UI components and the background (everything just turns white), not that the background isn't interesting enough.

@TheEgghead27
Copy link
Member

If I am understanding you correctly, you want to switch to raw CSS?

MUI ThemeProvider has ample dark/light features that work well, I wonder if the issue here is improper integration with it?

@SnowyNate
Copy link
Contributor

Ideally the site would have a minimal, sleek design, which I think having the ENTIRE background be a gradient goes against.

The problem with light theme is the lack of contrast between UI components and the background (everything just turns white), not that the background isn't interesting enough.

I see, then we would have to change the colors of the tiles themselves.

@SnowyNate
Copy link
Contributor

If I am understanding you correctly, you want to switch to raw CSS?

MUI ThemeProvider has ample dark/light features that work well, I wonder if the issue here is improper integration with it?

Yes, and use the Typescript to activate triggers in the CSS rather than handling the actual colors. Some backgrounds, such as the gradients I suggested, only work through CSS with our site. I tried using lineargradient inline and it broke the entire site.

@TheEgghead27
Copy link
Member

I have a feeling that what we actually need (readable light mode) is very much attainable without too many CSS hacks, and while gradiants look nice, I am of the opinion this disproportionately large struggle is not necessary.

@SnowyNate
Copy link
Contributor

I have a feeling that what we actually need (readable light mode) is very much attainable without too many CSS hacks, and while gradiants look nice, I am of the opinion this disproportionately large struggle is not necessary.

Alright then. It seems pretty universal that we should ditch the gradients then and maybe reserve them for a future update. I'll move onto attempting to change the colors of components themselves, such as the tiles.

@SnowyNate SnowyNate self-assigned this Jul 5, 2024
@SnowyNate
Copy link
Contributor

SnowyNate commented Jul 6, 2024

After performing some more experimentation, changing the colors of components themselves such as the tiles is also not very sufficient. Changing the tiles to a different color other than white makes them weirdly stand out, and making them darker also looks weird. Plus, if I stick with that idea, then I have to go hunting for every component and tile that the site has. While I understand Randy's desire for the site to be sleek and minimalistic, at this point, I'm going to consider my two options and go with whatever's easier and most visually appealing.

@SnowyNate
Copy link
Contributor

I have not been able to find a suitable solution for this yet, so I will unassign myself from this issue in case someone else wants to claim it.

@SnowyNate SnowyNate removed their assignment Jul 19, 2024
@TheEgghead27
Copy link
Member

I am under the impression that the light theme is acceptable at this time, and that there may be no need to change it substantially (only ideas I have might be to adjust the cyan accent color to be darker) -- thoughts?

@SnowyNate
Copy link
Contributor

It is acceptable for now. If we changed the accent color to be darker... it just wouldn't look good imo for light mode. This issue hopefully will be fixed in a UI overhaul.

@Rahuldeb5 Rahuldeb5 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants