Support PHP 8 and Symfony 6 #982
Conversation
|
Would you like squash all those commits into one? |
Done |
|
@stephanvierkant @stwe @Seb33300 would you like to review and merge this code? It looks ok |
composer.json
Outdated
| "phpunit/phpunit": "^7.5|^8.5", | ||
| "friendsofphp/php-cs-fixer": "^2.15" | ||
| "phpunit/phpunit": "^8.5|^9.5", | ||
| "friendsofphp/php-cs-fixer": "^3.0" |
There was a problem hiding this comment.
If you upgrade PHP-cs-fixer from version 2 to 3, you need to upgrade the config file .php_cs.dist to the new format .php-cs-fixer.dist.php
There was a problem hiding this comment.
Do you also prefer that I commit all changes made by php-cs-fixer when running?
It changes 13 files unrelated to my modifications but due to updated rules.
There was a problem hiding this comment.
IMO it should be better to upgrade php-cs-fixer in a separate PR first with all related changes
And then this PR only for PHP 8 / SF 6 upgrade
There was a problem hiding this comment.
Agreed that if possible that should be better.. however php-cs-fixer ^2 doesn't support Symfony 6 at all, so composer won't install Symfony 6 if I keep composer ^2 and I couldn't create this PR :-)
There was a problem hiding this comment.
Yes but I will merge the other PR before this one
|
PR for php-cs-fixer is merged. Please rebase this PR |
done :-) |
No description provided.