chore(flow): Update types on directional shorthands

Update types on directional shorthands to properly show values array elements are nullable.
styled-components · Dec 17, 2016 · e1feb49 · e1feb49
1 parent 72c3dd3
commit e1feb49
Show file tree

Hide file tree

Showing 8 changed files with 47 additions and 567 deletions.
diff --git a/docs/docs/index.html b/docs/docs/index.html
diff --git a/src/helpers/directionalProperty.js b/src/helpers/directionalProperty.js
@@ -8,7 +8,7 @@ function generateProperty(property: string, position: string) {
   return splitPropertyName.join('-')
 }
 
-function generateStyles(property: string, valuesWithDefaults: Array<string|null>) {
+function generateStyles(property: string, valuesWithDefaults: Array<?string>) {
   const styles = {}
   for (let i = 0; i < valuesWithDefaults.length; i += 1) {
     if (valuesWithDefaults[i]) {
@@ -41,7 +41,7 @@ function generateStyles(property: string, valuesWithDefaults: Array<string|null>
  * }
  */
 
-function directionalProperty(property: string, ...values: Array<string|null>) {
+function directionalProperty(property: string, ...values: Array<?string>) {
   // $FlowIgnoreNextLine doesn't understand destructuring with chained defaults.
   const [firstValue, secondValue = firstValue, thirdValue = firstValue, fourthValue = secondValue] = values
   const valuesWithDefaults = [firstValue, secondValue, thirdValue, fourthValue]

diff --git a/src/shorthands/borderColor.js b/src/shorthands/borderColor.js
@@ -24,7 +24,7 @@ import directionalProperty from '../helpers/directionalProperty'
  * }
  */
 
-function borderColor(...values: Array<string|null>) {
+function borderColor(...values: Array<?string>) {
   return directionalProperty('border-color', ...values)
 }
 

diff --git a/src/shorthands/borderStyle.js b/src/shorthands/borderStyle.js
@@ -24,7 +24,7 @@ import directionalProperty from '../helpers/directionalProperty'
  * }
  */
 
-function borderStyle(...values: Array<string|null>) {
+function borderStyle(...values: Array<?string>) {
   return directionalProperty('border-style', ...values)
 }
 

diff --git a/src/shorthands/borderWidth.js b/src/shorthands/borderWidth.js
@@ -24,7 +24,7 @@ import directionalProperty from '../helpers/directionalProperty'
  * }
  */
 
-function borderWidth(...values: Array<string|null>) {
+function borderWidth(...values: Array<?string>) {
   return directionalProperty('border-width', ...values)
 }
 

diff --git a/src/shorthands/margin.js b/src/shorthands/margin.js
@@ -24,7 +24,7 @@ import directionalProperty from '../helpers/directionalProperty'
  * }
  */
 
-function margin(...values: Array<string|null>) {
+function margin(...values: Array<?string>) {
   return directionalProperty('margin', ...values)
 }
 

diff --git a/src/shorthands/padding.js b/src/shorthands/padding.js
@@ -24,7 +24,7 @@ import directionalProperty from '../helpers/directionalProperty'
  * }
  */
 
-function padding(...values: Array<string|null>) {
+function padding(...values: Array<?string>) {
   return directionalProperty('padding', ...values)
 }
 

diff --git a/src/shorthands/position.js b/src/shorthands/position.js
@@ -46,7 +46,7 @@ const positionMap = ['absolute', 'fixed', 'relative', 'static', 'sticky']
  * }
  */
 
-function position(positionKeyword: string|null, ...values: Array<string|null>) {
+function position(positionKeyword: string|null, ...values: Array<?string>) {
   if (positionMap.includes(positionKeyword)) {
     return {
       position: positionKeyword,