Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Flow Lib Defs #200

Closed
bhough opened this issue Jun 20, 2017 · 2 comments
Closed

Install Flow Lib Defs #200

bhough opened this issue Jun 20, 2017 · 2 comments
Labels
bug good first contribution

Comments

@bhough
Copy link
Contributor

bhough commented Jun 20, 2017 •
edited
Loading

We have not installed Flow libdefs for our dependencies. These leads to flow errors with our source code (#197).

We just need to run flow-typed install and commit the downloaded lib defs.
@bhough bhough mentioned this issue Jun 20, 2017
Closed
@luftywiranda13
Copy link
Contributor

luftywiranda13 commented Jun 20, 2017 •
edited
Loading

i did it on 53261fd @ #196 . but the libdefs are for our dependencies, not the polished itself. we still need to make libdefs for polished and submit them to flow-typed

@bhough
Copy link
Contributor Author

bhough commented Jun 20, 2017

@luftywiranda13 yep I created #202 for that.

@bhough bhough closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhough @luftywiranda13