Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel): use babel-preset-env #196

Closed

Conversation

luftywiranda13
Copy link
Contributor

@luftywiranda13 luftywiranda13 commented Jun 17, 2017

babel-preset-latest is deprecated
https://babeljs.io/docs/plugins/preset-latest/

close #195

@luftywiranda13
Copy link
Contributor Author

luftywiranda13 commented Jun 17, 2017

failed on script build:docs:site && build:docs:readme.
they're not related to the changes I made by this PR

@bhough
Copy link
Contributor

bhough commented Jun 18, 2017

@luftywiranda13 #199 will address the build issues with this PR. Also, looks like some unrelated additions in the flow-typed folder?

@luftywiranda13
Copy link
Contributor Author

@bhough I ran flow-typed update to get any libdefs from this project's dependencies provided by flow-typed.
I did that because I saw many missing libdefs in the ./flow-typed/ folder. maybe we need those libdefs in the future

@bhough bhough changed the title fix(babel): use babel-preset-env chore(babel): use babel-preset-env Jun 21, 2017
@bhough
Copy link
Contributor

bhough commented Jun 21, 2017

Closing in favor of #203. The documentation.js issue did a number on this PR and I can't get the docs to build correctly. Faster to just do a clean PR with the changes.

@bhough bhough closed this Jun 21, 2017
@luftywiranda13 luftywiranda13 deleted the bug/babel-preset branch June 21, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-preset-latest is deprecated
2 participants