Add Timing Functions Mixin #20
Conversation
Current coverage is 100% (diff: 100%)@@ master #20 diff @@
===================================
Files 4 5 +1
Lines 7 9 +2
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 7 9 +2
Misses 0 0
Partials 0 0
|
|
@mxstbr this is ready for review, but wanted your thoughts on how we want to return static values like this. My thought is having a function that returns it would keep it consistent with similar mixins that do work behind the scenes (like strip unit). That way the API is always the same. Thoughts? |
|
I like it! What about adding a list of the functions we support to the docs? |
|
good idea! |
bhough
force-pushed
the
timing-functions
branch
from
6dcbfff
to
b22642e
Compare
Add mixin that returns a given cubic-bezier timing function for use in animations Addresses line item in #1
Fix error in documentation n/a
Generate documentation for timingFunctions n/a
Updated docs for timingFunctions and added better exclusions to speed up doc generation. n/a
Regenerate docs n/a
bhough
force-pushed
the
timing-functions
branch
from
db04b9f
to
e5117ef
Compare
|
Added to docs and ready for review. |
|
This LGTM, except for this:
Any way to fix that overflowing list? I'm sure there could be a better display for them. |
Bring theme into the repo so that we can address current bugs and with an eye towards full theme customization. n/a
|
So this turned out to be a bug of sorts with the theme instead of with how we are displaying it. Since we are going to need to customize the theme anyway, I brought the theme into the repo and fixed the bug on our copy that we will customize further later. Should be good to ship now once you approve. |
Addresses line item in #1