Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): Improve the library size for webpack #204

Merged
merged 6 commits into from Jun 23, 2017

Conversation

iamakulov
Copy link
Contributor

@iamakulov iamakulov commented Jun 23, 2017

@iamakulov
Copy link
Contributor Author

iamakulov commented Jun 23, 2017

There’s something wrong with 9a57c85. Will try to re-generate the assets now

@iamakulov
Copy link
Contributor Author

iamakulov commented Jun 23, 2017

Done.

@@ -845,7 +845,7 @@ <h3 class='fl m0' id='clearfix'>
</h3>


<a class='fr fill-darken0 round round pad1x quiet h5' href='https://github.com/styled-components/polished/blob/c5ccb3bf1c210d26eb3c2a3b7ab71a817b49e7b3/src/mixins/clearFix.js#L26-L35'>
<a class='fr fill-darken0 round round pad1x quiet h5' href='https://github.com/iamakulov/polished/blob/9a57c85ee212dd49b3736dcd65b49d75c0a3ea0c/src/mixins/clearFix.js#L26-L35'>
Copy link
Contributor Author

@iamakulov iamakulov Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about these changes. It that because of a different origin? Should I fix it?

Copy link
Contributor Author

@iamakulov iamakulov Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, fixed that.

@iamakulov
Copy link
Contributor Author

iamakulov commented Jun 23, 2017

OK, now looks like really done. Tests on the last commit errored because yarn failed to download, should be fine after re-launch.

@terales
Copy link

terales commented Jun 23, 2017

Here is a link to case study: https://iamakulov.com/notes/polished-webpack/

@codecov
Copy link

codecov bot commented Jun 23, 2017

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #204   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          64     66    +2     
  Lines         350    365   +15     
  Branches       98     98           
=====================================
+ Hits          350    365   +15
Impacted Files Coverage Δ
src/color/desaturate.js 100% <100%> (ø) ⬆️
src/color/shade.js 100% <100%> (ø) ⬆️
src/color/saturate.js 100% <100%> (ø) ⬆️
src/color/setLightness.js 100% <100%> (ø) ⬆️
src/color/setSaturation.js 100% <100%> (ø) ⬆️
src/helpers/rem.js 100% <100%> (ø)
src/color/mix.js 100% <100%> (ø) ⬆️
src/color/adjustHue.js 100% <100%> (ø) ⬆️
src/color/tint.js 100% <100%> (ø) ⬆️
src/color/setHue.js 100% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f127e0c...bfce9e2. Read the comment docs.

@bhough bhough changed the title Improve the library size for webpack fix(color): Improve the library size for webpack Jun 23, 2017
bhough
bhough approved these changes Jun 23, 2017
@bhough bhough merged commit 7343037 into styled-components:master Jun 23, 2017
3 checks passed
@iamakulov iamakulov deleted the improve-size-for-webpack branch Jun 23, 2017
@Siyfion
Copy link

Siyfion commented Jun 23, 2017

Great article and fantastic work @iamakulov!

@nikgraf
Copy link
Member

nikgraf commented Jun 27, 2017

Wow, really great article and good work on the PR @iamakulov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants