-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(color): Improve the library size for webpack #204
fix(color): Improve the library size for webpack #204
Conversation
See https://iamakulov.com/notes/polished-webpack/ for the decisions behind the change
There’s something wrong with 9a57c85. Will try to re-generate the assets now |
Done. |
docs/docs/index.html
Outdated
@@ -845,7 +845,7 @@ <h3 class='fl m0' id='clearfix'> | |||
</h3> | |||
|
|||
|
|||
<a class='fr fill-darken0 round round pad1x quiet h5' href='https://github.com/styled-components/polished/blob/c5ccb3bf1c210d26eb3c2a3b7ab71a817b49e7b3/src/mixins/clearFix.js#L26-L35'> | |||
<a class='fr fill-darken0 round round pad1x quiet h5' href='https://github.com/iamakulov/polished/blob/9a57c85ee212dd49b3736dcd65b49d75c0a3ea0c/src/mixins/clearFix.js#L26-L35'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about these changes. It that because of a different origin
? Should I fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, fixed that.
OK, now looks like really done. Tests on the last commit errored because yarn failed to download, should be fine after re-launch. |
Here is a link to case study: https://iamakulov.com/notes/polished-webpack/ |
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 64 66 +2
Lines 350 365 +15
Branches 98 98
=====================================
+ Hits 350 365 +15
Continue to review full report at Codecov.
|
Great article and fantastic work @iamakulov! |
Wow, really great article and good work on the PR @iamakulov ✨ |
Follow-up after https://twitter.com/b_hough/status/878015824056942592