build(typescript): Removes typescript and tsgen

[bhough]

Removes typescript tests and tsgen auto typing

BREAKING CHANGE: Anyone using typescript will lose typings with this release.

fix #276 #250

[codecov]

Codecov Report

Merging #295 into version-2 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           version-2   #295   +/-   ##
========================================
  Coverage        100%   100%           
========================================
  Files             70     70           
  Lines            388    388           
  Branches         102    102           
========================================
  Hits             388    388

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee912ff...1ff6a83. Read the comment docs.

[ForbesLindesay]

What!!!!!!!!!!!!!!!!!!!!!!! I put a fair bit of work into adding tyepscript support for this library, and was happy to help maintain it. Why is it suddenly getting removed without warning?

[mxstbr]

:thinking_face:

[mxstbr]

I'm curious too

[ForbesLindesay]

@mxstbr can we revert this and maybe open issues on tsgen for anything that needs fixing to resolve this?

[mxstbr]

Yeah sure, I wonder why @bhough removed that though. Haven't stayed up to date with dev of this pkg so don't have any bg information.

[bhough]

@ForbesLindesay @mxstbr I'm removing it because it has caused a variety of issues that have either had an issue filed directly (ForbesLindesay/tsgen#2) or have pinged you on on our issue (#250). And it appears that it may not even be fully working (#276).

It has blocked a variety of modules, contributions, and changes from going live and I needed to move forward with it. In the past, the response has been for us to submit a PR, and right now given I'm the only one of us maintaining polished, I don't have the time to also troubleshoot tsgen in order to get items out.

Right now this is not in the production build, so open to a discussion on how to move forward, but as of now I'm leaving it out so I can get things moving forward towards 2.0.

[ForbesLindesay]

#250 is a pain for me to solve as I'll have to set up a windows VM to reproduce, but I can have a go if it's truly breaking.

I will add a config option to resolve #276 - I was using the allow synthetic default export option for my typescript app. If you were using the default transform to ES Modules this would work fine anyway, but you're compiling to CommonJS style.

I'll fix the tuples issue, I didn't know it was a big enough problem to lead to you dropping the library on polished.

[bhough]

On #250 it has prevented a few contributors from contributing since they are on Windows. We did a bunch of work to ensure the whole build worked in Windows for them, so this resulted in a regression for them.

On #276 does that mean only one or the other will work for typescript apps depending on how they have theirs configured?

I'm planning on going back through the flow defs as part of 2.0 and provide a lot stricter type safety. Tuples are a huge way of doing this for us, since we have a lot of modules with multiple api signatures.

Very much appreciate the help sorting these issues out.

[ForbesLindesay]

On #276 does that mean only one or the other will work for typescript apps depending on how they have theirs configured?

No, the current type definitions are incorrect. Unlike flow, typescript differentiates between export default and module.exports =. There is a special mode that lets you treat them as equivalent, but if we get the library definitions correct, it won't matter which mode the consumer is using. Since you are doing module.exports = you'll need to put tsgen in the "Common JS Default Export" mode that is I'm about to add.

[ForbesLindesay]

tsgen 1.1.0 with the --common-js-default-export flag should fix everything apart from the windows support.

[ForbesLindesay]

Version 1.1.1 should slightly improve the error message, but I can't think of anything that would be causing this to break. Is this sufficient for you to re-introduce typescript definitions?

[Ponjimon]

If I can leave my bits here.

I noticed in my own project that:
"build:flow": "flow-copy-source -v -i '{**/*.spec.js}' src lib"
is not ignoring .spec.js files as it should be, they are still converted to .js.flow files.

If I change it to:
"build:flow": "flow-copy-source -v -i **/*.spec.js src lib"
then they are successfully ignored and then the build:typescript task should also run through.

That seems to be contrary to what the author of that lib said, but that's also what I noticed.
Macil/flow-copy-source#2

[resir014]

Hey, I'm in favour of bringing TypeScript back. Lack of typings will definitely prevent me from upgrading to 2.0 in my projects. Let me know how I could be of any help.

[bhough]

@resir014 I have a branch where I'm looking at @ForbesLindesay's changes: https://github.com/styled-components/polished/tree/readd-tsgen if you want to track progress on keeping it in 2.0.