Integrate documentation.js #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #37 diff @@
===================================
Files 7 7
Lines 12 12
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 12 12
Misses 0 0
Partials 0 0
|
|
Let's 馃殺 this first thing @bhough! Can you review & merge? |
bhough
requested changes
Dec 9, 2016
| @@ -55,6 +55,7 @@ | |||
| "babel-preset-latest": "^6.16.0", | |||
| "cz-conventional-changelog": "^1.2.0", | |||
| "docdash": "^0.4.0", | |||
| "documentation": "^4.0.0-beta16", | |||
There was a problem hiding this comment.
Should we remove the JSDocs and associated Babel plugin as a dependency now?
There was a problem hiding this comment.
Arg yes we should, good catch! Mind doing that and pushing to the branch?
Remove npm packages leftover from previous JSDocs implementation.
bhough
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so nice! Looks like a huge PR, but is actually much less code now since the theme is no longer inlined. I was able to remove almost all JSDoc comments (except for the examples) in favor of flow types, and documentation understood everything perfectly! 馃槺 So super cool!
This is what it looks like right now, which to be honest I quite like!
Whatcha think @bhough?
Ref: #31