Rgb #53
Merged
Rgb #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #53 diff @@
===================================
Files 18 21 +3
Lines 73 84 +11
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 73 84 +11
Misses 0 0
Partials 0 0
|
mxstbr
reviewed
Dec 15, 2016
|
|
||
| function toHex(value) { | ||
| const hex = value.toString(16) | ||
| return hex.length === 1 ? `0${hex}` : hex |
There was a problem hiding this comment.
When is hex ever just one character and why do we prefix 0 in that case?
There was a problem hiding this comment.
If you create the hex of 0 it will be '0'. The issue here at hand is that only of 3 parts of a hex color can be reduced only then it should be. Otherwise two characters e.g. prefixed with a 0 are required.
|
Looks amazing, just the short hex notations and then let's 🚢 |
mxstbr
requested changes
Dec 17, 2016
mxstbr
approved these changes
Dec 17, 2016
|
Great to see the color portion of this underway, thanks for the contribution @nikgraf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one thing missing is to reduce the hex values e.g.
#ffffffto#fff. I will add this sometime later.