Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theme interface example for TypeScript #374

Closed
wants to merge 2 commits into from
Closed

Fix theme interface example for TypeScript #374

wants to merge 2 commits into from

Conversation

nickmccurdy
Copy link

Fix #373

@vercel
Copy link

vercel bot commented Oct 26, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@nickmccurdy nickmccurdy mentioned this pull request Oct 26, 2018
Closed
@morajabi
Copy link
Member

Thanks! Let's also add withTheme. What do you think?

Igorbek
Igorbek previously approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@Igorbek Igorbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@quantizor
Copy link
Contributor

Thanks for the review @Igorbek

@nickmccurdy
Copy link
Author

Looking at the diff, this PR only reorders two lines now. Was this already merged upstream?

@quantizor
Copy link
Contributor

Oh hmm. Not sure

@Igorbek
Copy link
Contributor

Igorbek commented Nov 6, 2018

that's because #383 got merged

@nickmccurdy nickmccurdy closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Igorbek Igorbek Igorbek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nickmccurdy @morajabi @quantizor @Igorbek