Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#503 added useTheme hook documentation #569

Merged
merged 10 commits into from
Nov 28, 2021
Merged

#503 added useTheme hook documentation #569

merged 10 commits into from
Nov 28, 2021

Conversation

arthurfalcao
Copy link
Contributor

Related issue: #503

Added useTheme hook in api helpers section

@vercel
Copy link

vercel bot commented Oct 31, 2019 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styledcomponents/styled-components/CSeMkNP1bbbtUtdZWrkpauZAiyw2
✅ Preview: https://styled-components-git-fork-arthurfalcao-b9ffb3-styledcomponents.vercel.app

el1f
el1f requested changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@el1f el1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off to a great start @arthurfalcao! Thanks!
Can you please try your hand at adding a couple of words about the hook on the theming section too though? There is a paragraph about accessing the theme using the useContext hook to get the theme, I think it could be integrated or even replaced by a mention of useTheme.

@quantizor
Copy link
Contributor

/bump @arthurfalcao

@vzaidman
Copy link
Contributor

vzaidman commented May 5, 2020

any help needed with this one?

@arthurfalcao
Copy link
Contributor Author

any help needed with this one?

just needs to be reviewed

el1f
el1f approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@el1f el1f left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

The only nitpick that I have is that IMO useTheme should come before useContext in the docs but that's probably quite subjective. Do you have any further comments on this @probablyup ?

@arthurfalcao arthurfalcao requested a review from el1f June 16, 2020 00:29
quantizor
quantizor approved these changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quantizor quantizor enabled auto-merge (squash) November 28, 2021 17:12
@quantizor quantizor mentioned this pull request Nov 28, 2021
Closed
@quantizor quantizor merged commit 665aa17 into styled-components:main Nov 28, 2021
@arthurfalcao arthurfalcao deleted the feature/use-theme-section branch November 28, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor approved these changes

@el1f el1f Awaiting requested review from el1f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arthurfalcao @quantizor @vzaidman @el1f