Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to import keyframes helper #59

Closed

Conversation

TrevorBurnham
Copy link

The Basics page doesn't show keyframes being imported, leaving some ambiguity about where that helper comes from. It is styled.keyframes? import 'styled-components/keyframes'? I've tried to clarify here.

Ideally the import statement would be in the live code sample, but I've settled for putting it in the preceding description.

@kitten
Copy link
Member

kitten commented Jul 14, 2017

Ok, so the text you added adds what is already stated in the paragraph before, and deletes text that tells the user what it means to use it. Instead we can use the <Note> component and just say sth along the lines of:

keyframes, like other helpers, is another export of the library. You can import it as follows: import { keyframes } from 'styled-components'

Additionally to this, we probably need to write another section in "Getting Started" that speaks about the imports briefly.

@TrevorBurnham
Copy link
Author

Sounds good to me. 👍 I'll leave it to you to figure out the best approach here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants