-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel plugin #62
Babel plugin #62
Changes from 2 commits
33fea5f
b6acb46
8edd7b0
028cef8
cf566a7
ad8c1c1
6b4bf98
13c7ee3
8652658
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,165 @@ | ||
import React from 'react'; | ||
import SectionLayout from '../SectionLayout'; | ||
import CodeBlock from '../CodeBlock'; | ||
import Code from '../Code'; | ||
import Note from '../Note'; | ||
|
||
const installNPM = ` | ||
npm install --save-dev babel-plugin-styled-components | ||
`.trim(); | ||
|
||
const usage = ` | ||
{ | ||
"plugins": ["styled-components"] | ||
} | ||
`.trim(); | ||
|
||
const ssr = ` | ||
{ | ||
"plugins": [ | ||
["styled-components", { | ||
"ssr": true | ||
}] | ||
] | ||
} | ||
`.trim(); | ||
|
||
const displayName = ` | ||
{ | ||
"plugins": [ | ||
["styled-components", { | ||
"displayName": false | ||
}] | ||
] | ||
} | ||
`.trim(); | ||
|
||
const preprocess = ` | ||
{ | ||
"plugins": [ | ||
["styled-components", { | ||
"preprocess": true | ||
}] | ||
] | ||
} | ||
`.trim(); | ||
|
||
const minify = ` | ||
{ | ||
"plugins": [ | ||
["styled-components", { | ||
"minify": false | ||
}] | ||
] | ||
} | ||
`.trim(); | ||
|
||
const BabelPlugin = () => | ||
<SectionLayout title="Babel Plugin" labels={['v2']}> | ||
<p> | ||
This plugin adds support for server-side rendering, for minification of | ||
styles and gives you a nicer debugging experience when using{' '} | ||
<Code>styled-components</Code>. | ||
</p> | ||
<p>Usage</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This subsection can use the Also, this is missing a small explanation, like:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done 🌮 |
||
<CodeBlock code={installNPM} language="node" /> | ||
<p> | ||
Then in your babel configuration (probably <Code>.babelrc</Code>): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sounds a bit odd. Maybe something like:
would make it nicer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed 👍 |
||
</p> | ||
<CodeBlock code={usage} language="node" /> | ||
<SectionLayout sub title="Server-side rendering"> | ||
<Note>This option is turned off by default</Note> | ||
<p> | ||
By adding a unique identifier to every styled component this plugin | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sorry ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just indicating that we need to replace the mention of "this plugin" with "this option" since each section only talks about a single option :) |
||
avoids checksum mismatches due to different class generation on the | ||
client and on the server. If you do not use this plugin and try to | ||
server-side render <Code>styled-components</Code> React will complain. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is a bit outdated and also sounds weird, so let's update it:
We also need to add a reference to this babel-plugin option to our SSR section. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We also need to add a reference to this babel-plugin option to our SSR section. -> What can I do here ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can do this, if it's unclear. In the SSR section on the website, it'd just be useful to say "You will probably need to use our babel plugin's |
||
</p> | ||
<p> | ||
If you want server-side rendering support you can enable it with the{' '} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can cut this short due to the prior intro:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done 🎉 |
||
<Code>ssr</Code> option: | ||
</p> | ||
<CodeBlock code={ssr} language="node" /> | ||
</SectionLayout> | ||
<SectionLayout sub title="Better debugging"> | ||
<p> | ||
This babel plugin adds the components' name to the class name attached | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Also maybe we should mention that it sets a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, that sounds a bit wrong ^^" Maybe more like:
(We can't say "DOM node" since it might also be passed to a component) |
||
to the DOM node. In your browsers DevTools you'll see:{' '} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed 😄 |
||
<Code> | ||
<button class="sc-Button-asdf123 asdf123" /> | ||
</Code>{' '} | ||
instead of just <Code><button class="asdf123" /></Code>. | ||
</p> | ||
<p> | ||
This also adds support for showing your components' real name in the | ||
React DevTools. They will normally show{' '} | ||
<Code><styled.button></Code> for all of your components, but with | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The examples here are nice, but they're missing reference code. It should probably intro with:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed 👍 |
||
this plugin they show <Code><MyButton /></Code>. | ||
</p> | ||
<p> | ||
This makes it easier to find your components and to figure out where | ||
they live in your app. | ||
</p> | ||
<p> | ||
If you don't need this feature, you can disable it with the{' '} | ||
<Code>displayName</Code> option: | ||
</p> | ||
<CodeBlock code={displayName} language="node" /> | ||
</SectionLayout> | ||
<SectionLayout sub title="Preprocessing"> | ||
<Note> | ||
This is experimental and we don't yet know of all limitations and bugs! | ||
Consider this non-production ready for now. ⚠️ | ||
</Note> | ||
<p> | ||
This plugin preprocesses your styles with stylis and uses the{' '} | ||
<Code>no-parser.js</Code> entrypoint on styled-components. | ||
</p> | ||
<p> | ||
This effectively removes stylis from your runtime bundle and should | ||
slightly improve runtime performance and shrink your bundle size. | ||
</p> | ||
<p> | ||
It automatically disables the <Code>minify</Code> option, since stylis | ||
already does some minification on your CSS. | ||
</p> | ||
<p> | ||
You can enable preprocessing with the <Code>preprocess</Code> option: | ||
</p> | ||
<CodeBlock code={preprocess} language="node" /> | ||
</SectionLayout> | ||
<SectionLayout sub title="Preprocessing"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incorrect title 😉 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Damn , fixed :p |
||
<Note> | ||
This option is turned on by default! If you experience mangled CSS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can lose the exclamation mark here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done 😄 |
||
results, turn it off and open an issue please. | ||
</Note> | ||
<p> | ||
This plugin minifies your styles in the tagged template literals, giving | ||
you big bundle size savings. (note that you will not see the effect of | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can lose the parantheses here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed 💃 |
||
minification in generated <Code><style></Code> tags, it solely | ||
affects the style strings inside your JS bundle) | ||
</p> | ||
<Note> | ||
This operation may potentially break your styles in some rare cases, so | ||
we recommend to keep this option enabled in development if it's enabled | ||
in the production build. | ||
</Note> | ||
<p> | ||
You can disable minification with the <Code>minify</Code> option: | ||
</p> | ||
<CodeBlock code={minify} language="node" /> | ||
<p> | ||
We also transpile <Code>styled-components</Code> tagged template | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should go into a new section, since it's a separate option actually. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What should go in this section ? Just this paragraph ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea, this entire part about the template string transpilation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
literals down to a smaller representation than what Babel normally does, | ||
because <Code>styled-components</Code> template literals don't need to | ||
be 100% spec compliant. see{' '} | ||
<a href="https://github.com/styled-components/babel-plugin-styled-components/blob/master/minification.md"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The link here can be swapped out for a link to our "Tagged Template Literals" section. Also there's a trailing closed parenthesis below. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Link swapped :) |
||
minification.md | ||
</a>{' '} | ||
for more information about that) You can use the | ||
<Code>transpileTemplateLiterals</Code> option to turn this feature off. | ||
</p> | ||
</SectionLayout> | ||
</SectionLayout>; | ||
|
||
export default BabelPlugin; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,69 +6,94 @@ | |
"sections": [ | ||
{ | ||
"title": "Motivation" | ||
}, { | ||
}, | ||
{ | ||
"title": "Installation" | ||
}, { | ||
}, | ||
{ | ||
"title": "Getting Started" | ||
}, { | ||
}, | ||
{ | ||
"title": "Passed props" | ||
}, { | ||
}, | ||
{ | ||
"title": "Adapting based on props" | ||
}, { | ||
}, | ||
{ | ||
"title": "Styling any components" | ||
}, { | ||
}, | ||
{ | ||
"title": "Extending styles" | ||
}, { | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prettier auto did this , should I revert ? |
||
{ | ||
"title": "Attaching additional props" | ||
}, { | ||
}, | ||
{ | ||
"title": "Animations" | ||
}, { | ||
}, | ||
{ | ||
"title": "React Native" | ||
} | ||
] | ||
}, { | ||
}, | ||
{ | ||
"title": "Advanced", | ||
"pathname": "advanced", | ||
"sections": [ | ||
{ | ||
"title": "Theming" | ||
}, { | ||
}, | ||
{ | ||
"title": "Refs" | ||
}, { | ||
}, | ||
{ | ||
"title": "Security" | ||
}, { | ||
}, | ||
{ | ||
"title": "Existing CSS" | ||
}, { | ||
}, | ||
{ | ||
"title": "Media Templates" | ||
}, { | ||
}, | ||
{ | ||
"title": "Tagged Template Literals" | ||
}, { | ||
}, | ||
{ | ||
"title": "Server Side Rendering" | ||
}, | ||
{ | ||
"title": "Babel Plugin" | ||
} | ||
] | ||
}, { | ||
}, | ||
{ | ||
"title": "API Reference", | ||
"pathname": "api", | ||
"sections": [ | ||
{ | ||
"title": "Primary" | ||
}, { | ||
}, | ||
{ | ||
"title": "Helpers" | ||
}, { | ||
}, | ||
{ | ||
"title": "Supported CSS" | ||
}, { | ||
}, | ||
{ | ||
"title": "Flow" | ||
}, { | ||
}, | ||
{ | ||
"title": "TypeScript" | ||
} | ||
] | ||
}, { | ||
}, | ||
{ | ||
"title": "FAQs", | ||
"pathname": "faqs", | ||
"sections": [ | ||
{"title": "Can I nest rules?"}, | ||
{"title": "Can I refer to other components?"}, | ||
{"title": "Can I use css frameworks?"} | ||
{ "title": "Can I nest rules?" }, | ||
{ "title": "Can I refer to other components?" }, | ||
{ "title": "Can I use css frameworks?" } | ||
] | ||
} | ||
] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,17 @@ | ||
import React from 'react' | ||
import DocsLayout from '../../components/DocsLayout' | ||
import NextPage from '../../components/NextPage' | ||
import React from 'react'; | ||
import DocsLayout from '../../components/DocsLayout'; | ||
import NextPage from '../../components/NextPage'; | ||
|
||
import Theming from '../../components/advanced/theming' | ||
import Refs from '../../components/advanced/refs' | ||
import Security from '../../components/advanced/security' | ||
import ExistingCSS from '../../components/advanced/existing-css' | ||
import MediaTemplates from '../../components/advanced/media-templates' | ||
import TaggedTemplateLiterals from '../../components/advanced/tagged-template-literals' | ||
import ServerSideRendering from '../../components/advanced/server-side-rendering' | ||
import Theming from '../../components/advanced/theming'; | ||
import Refs from '../../components/advanced/refs'; | ||
import Security from '../../components/advanced/security'; | ||
import ExistingCSS from '../../components/advanced/existing-css'; | ||
import MediaTemplates from '../../components/advanced/media-templates'; | ||
import TaggedTemplateLiterals from '../../components/advanced/tagged-template-literals'; | ||
import ServerSideRendering from '../../components/advanced/server-side-rendering'; | ||
import BabelPlugin from '../../components/advanced/babel-plugin'; | ||
|
||
const Advanced = () => ( | ||
const Advanced = () => | ||
<DocsLayout title="Advanced"> | ||
<Theming /> | ||
<Refs /> | ||
|
@@ -19,12 +20,9 @@ const Advanced = () => ( | |
<MediaTemplates /> | ||
<TaggedTemplateLiterals /> | ||
<ServerSideRendering /> | ||
<BabelPlugin /> | ||
|
||
<NextPage | ||
href="/docs/api" | ||
title="API Reference" | ||
/> | ||
</DocsLayout> | ||
) | ||
<NextPage href="/docs/api" title="API Reference" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prettier again There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No worries! I might add prettier soon anyway There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome ! I can do that if you want 👍 |
||
</DocsLayout>; | ||
|
||
export default Advanced | ||
export default Advanced; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave out "when using styled-components" as that's quite obvious on the site. But we should add a paragraph that it's only for the web, not for React Native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 🎉