"Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead"

[wle8300]

I'm getting this error. I believe the warning is originating from either:

a) styled-components
b) one of its deps

I'm using create-react-app and my only added dep is styled-components. Removing styled-components makes the warning message go away.

[k15a]

That's already fixed in master and v2. Just needs to be published.

[nic]

Reference: #668

[rovansteen]

@k15a this should be fixed in 1.4.5 right? At least that's what the changelog says, still getting the warning tho.

If I look where it's coming from: styled-components/lib/types.js which contains the following compiled code:

"use strict";

/* todo: I want this to actually be an array of Function | string but that causes errors */
Object.defineProperty(module.exports, "babelPluginFlowReactPropTypes_proptype_GlamorRule", {
  value: require("react").PropTypes.shape({
    cssText: require("react").PropTypes.string.isRequired
  })
});

/* eslint-disable no-undef */

[kitten]

@rovansteen that explains a lot actually! Thanks!
We should maybe just remove the plugin. As far as I know it's not doing anything for us anyway

[jeffscottward]

.... sooo ... you gonna fix it now? @philpl

[kitten]

@jeffscottward should be fixed with the new version of babel-plugin-flow-react-proptypes in v2 RC

[kachkaev]

It’d be great to see a new release in 1.x branch with this fix too. Could anyone please release 1.4.6?

[kolelee4]

I'm still getting this warning. @jeffscottward How did you get around this?

[jeffscottward]

I went through the whole lib folder and replaced the require('react').PropTypes with
var PropTypes = require('prop-types');
Proptypes.blahbblah

Here is the folder zipped up
styled-components.zip

[wle8300]

@jeffscottward probably not the best idea because the new release will overwrite everything

[kolelee4]

@jeffscottward Thank you. @williamle8300 When is the next release?

[wle8300]

I'm not a contributor! Just saying that editing the libs folder is gonna create more headache. Just wait till they decide to cut a release

…

On May 1, 2017, at 9:11 PM, Kole Lee ***@***.***> wrote: @jeffscottward Thank you. @williamle8300 When is the next release? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kachkaev]

@k15a @philpl @geelen could you please reopen this issue meanwhile and even maybe release 1.4.x? There must be thousands of devs who see the warning now 😃

Switching to v2 until it’s stable is something most of us would probably prefer to avoid.

[kitten]

@kachkaev This should be fixed with the 1.4.6 release which has just gone out 😄

[jeffscottward]

@williamle8300 "waiting to cut a realease" is not an option in a production environment. I would appreciate you didn't down vote people who come up with a temporary emergency fix and share it with the community.

[wle8300]

It is an option because builds will silence React's warning logs. Your can't feel entitled to receive work from the repo contributors unless you actually commit work to this repo. Submit a pull request or smthng...

…

On May 2, 2017, at 10:35 AM, Jeff Ward ***@***.***> wrote: @williamle8300 "waiting to cut a realease" is not an option in a production environment. I would appreciate you didn't down vote people who come up with a temporary emergency fix and share it with the community. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kitten]

@jeffscottward @williamle8300 As our code of conduct states, we expect respectful conversations amongst members of our community. Please refrain from derogatory remarks. https://github.com/styled-components/styled-components/blob/master/CODE_OF_CONDUCT.md

[wle8300]

@philpl Edited my comment.