Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from the deprecated React.propTypes to prop-types package #668

Merged
merged 2 commits into from Apr 8, 2017

Conversation

yasserkaddour
Copy link
Contributor

Fix #667

@mxstbr-bot
Copy link

mxstbr-bot commented Apr 8, 2017

Warnings
⚠️ ❗ Big PR
⚠️ There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@kitten
Copy link
Member

kitten commented Apr 8, 2017

Lgtm! Mind submitting a similar PR against the v2 branch?

@kitten kitten merged commit f52e467 into styled-components:master Apr 8, 2017
@yasserkaddour yasserkaddour deleted the proptype-master branch April 8, 2017 15:37
@yasserkaddour
Copy link
Contributor Author

@philpl done in #670 ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants