New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static attrs caching #1219
Static attrs caching #1219
Conversation
Generated by 🚫 dangerJS |
adb6eee
to
f4184ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, shipping this!
I don't know why you'd do that, we'll see if people complain I guess! |
@mxstbr wouldn’t that only be possible if the object is kept around and mutated or if the internals are being accessed? 😅 Definitely not supported, but possible I guess |
Possible for sure, but that's what I mean—let's wait and see if anybody actually complains, then think about fixing it 😅 |
@mxstbr I think one reason would be to integrate with 3rd party css libraries. For instance, PaperCSS has a popover property. You might want to change that dynamically. There might be a smarter way of doing that, just a thought. |
As mentioned in #1216, the static caching machinery introduced a regression;
attrs
were not considered during theisStatic
calculation.Note however that this assumes
attrs
will be static at component instantiation. Is dynamically changing the value ofcomponent.attrs
supported? If so I think we'll need to add a setter and dynamically recomputeisStatic