Fix w3c validation warning type style

[mdugue]

Summary

Removes type="text/css" from the <style /> tag, as it causes the warnings

The type attribute for the style element is not needed and should be omitted.

in w3c validator, see https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.styled-components.com%2F for an example.

Motivated by https://spectrum.chat/?thread=085d48f2-47e2-43ac-8459-500722a0ba3f

Tests looked fine, snapshots changed as expected. I couldn't see any problems with SSR, jest-styled-components or babel-plugin-styled-components.

TBD

Does styled-components support html 4 environments? If so, this PR should be adjusted to add the type attribute only if in html5-"mode"

[mxstbr-bot]

	Warnings
⚠️	There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

[kitten]

This is fine overall but can you explain why it is recommended to leave it out please? I’m not quite aware of the intricacies of having or not having it, but previously I was under the impression that it’s a best practice to specify the type 😅

[kitten]

Can you remove your formatting from this file please? It’s be great to preserve its previous history and format

[mdugue]

sorry, didn't realise , will revert later on

[mdugue]

fixed

[quantizor]

It used to be before html5. Now it’s just a legacy thing.

…

On Sat, Feb 24, 2018 at 10:57 AM Phil Plückthun ***@***.***> wrote: ***@***.**** commented on this pull request. This is fine overall but can you explain why it is recommended to leave it out please? I’m not quite aware of the intricacies of having or not having it, but previously I was under the impression that it’s a best practice to specify the type 😅 ------------------------------ In CHANGELOG.md <#1551 (comment)> : > @@ -2,414 +2,416 @@ All notable changes to this project will be documented in this file. If a contribution does not have a mention next to it, ***@***.***(https://github.com/geelen) or ***@***.***(https://github.com/mxstbr) did it. -*The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).* Can you remove your formatting from this file please? It’s be great to preserve its previous history and format — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1551 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy1rEAPQ8cPwNH--piN-AyRXbrD-Wvks5tYDFYgaJpZM4SR1wE> .

[mdugue]

@kitten right, its not hurting to include the type attribute, but since HTML5 it default to text/css and w3c validation considers its declaration redundant.

Do we have to consider pre html5 environments?

[kitten]

I’m a little concerned about IE9, but if this works for it that’d be awesome 😎

[mdugue]

I tested the sandbox in IE8, which didn't seem to have any Problems 😃

[mdugue]

Btw. I just checked https://emotion.sh/ out of curiosity. It doesn't seem to set type attributes either

[mxstbr]

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!