Move @import rules to an extra/separate browser tag inside tags #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxstbr
reviewed
Mar 6, 2018
| html{color:blue;}</style> | ||
| <style data-styled-components=\\"\\"> | ||
| /* sc-component-id: sc-global-1433896746-import */ | ||
| @import url('bla');</style>" |
There was a problem hiding this comment.
Shouldn't this style tag be above the other style tags? Or is it only about the first thing in a certain style tag?
There was a problem hiding this comment.
@mxstbr I could enforce it to come before the style tag that contains the @import actually. I'm not sure whether we'd want that, since it's mostly meant for fonts only anyway.
But I could modify the makeStyleTag method to allow me to inject elements before another
There was a problem hiding this comment.
Not sure, I mean if it works that's totally fine!
kitten
changed the title
When a BrowserTag or SpeedyTag detect an @import rule, which is expected to be the first rules in the array to arrive due to Stylis' reordering, then an extra tag is injected, and the @import rules are injected there instead. This ensures that it's *impossible* for an @import rule to not be at the beginning of a stylesheet.
kitten
force-pushed
the
hotfix/shard-for-import
branch
from
b084496
to
2e12f8e
Compare
kitten
force-pushed
the
hotfix/shard-for-import
branch
from
2e12f8e
to
980ffc7
Compare
quantizor
previously approved these changes
Mar 7, 2018
- Prevent creating multiple style tags for import at-rules - Create a single one a single time via the StyleSheet - Put it at the top of the other style tags
quantizor
approved these changes
Mar 7, 2018
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1574
When a BrowserTag or SpeedyTag detect an @import rule, which is expected
to be the first rules in the array to arrive due to Stylis' reordering,
then an extra tag is injected, and the @import rules are injected there
instead.
This ensures that it's impossible for an @import rule to not be at the
beginning of a stylesheet.
Published under
styled-components@devversion3.2.1-0for testing.