Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix objects with functions - replace (objToCss) with (objToCssArray) #2489
changed the title
Fix objects with methods - replace ObjectToCss => ObjectToArray
Apr 9, 2019
referenced this pull request
Apr 10, 2019
@mrmckeb I'm not 100% sure actually, but here is my understanding:
Using objects gets converted by styled-components and it gets slower with nested objects because you have to go through every key for each object.
So, based on my assumptions, using template literal is faster specially if the object contains nested objects.
I would like to hear from somebody who is fully aware of the project to verify or correct me if i'm wrong.
Yeah 4.x isn’t closed out yet…
On Thu, May 2, 2019 at 3:29 AM Abdel-Rhman ***@***.***> wrote: @probablyup <https://github.com/probablyup> is there any minor releases for bugs before merging canary into master? if so, will open a second PR for this. If not, will change the base branch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2489 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAELFVVLNTA4SWXAIFAMUM3PTKQ6XANCNFSM4HEWR53Q> .