Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise SSR+hydration functionality to be more fault-tolerant #3018

Merged
merged 8 commits into from Mar 5, 2020
Merged

revise SSR+hydration functionality to be more fault-tolerant #3018

merged 8 commits into from Mar 5, 2020

Conversation

kitten
Copy link
Member

@kitten kitten commented Feb 12, 2020

Fix #3017

@kitten kitten changed the title Fix RULE_RE to reduce backtracking Fix RULE_RE to reduce backtracking during Rehydration Feb 12, 2020
@kitten kitten mentioned this pull request Feb 12, 2020
Closed
@quantizor quantizor changed the title Fix RULE_RE to reduce backtracking during Rehydration revise SSR+hydration functionality to be more fault-tolerant Feb 12, 2020
quantizor
quantizor previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@quantizor
Copy link
Contributor

Published for testing under styled-components@5.0.1-revisedssr

abbyhowell
abbyhowell reviewed Feb 14, 2020
View reviewed changes
packages/styled-components/src/sheet/test/Rehydration.test.js Outdated Show resolved Hide resolved
packages/styled-components/src/sheet/test/Rehydration.test.js Outdated
"
.b {}",
"
data-styled.g22[id=\\"idB\\"]{content:\\"nameB,\\"}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the output double-escaped now when it wasn't before? That seems like an unwanted change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just a jest snapshot serialization artifact

@PaulACoroneos PaulACoroneos mentioned this pull request Feb 29, 2020
Closed
@quantizor quantizor force-pushed the fix/rehydration-backtracking branch from b06b432 to 0045550 Compare March 5, 2020 20:17
@quantizor quantizor merged commit e56952a into master Mar 5, 2020
@quantizor quantizor deleted the fix/rehydration-backtracking branch March 5, 2020 20:23
This was referenced Apr 9, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 9, 2020
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Closed
This was referenced Apr 30, 2020
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor left review comments

@abbyhowell abbyhowell abbyhowell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Rehydration regex causing infinite loops for malformed inputs
3 participants
@kitten @quantizor @abbyhowell