Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise SSR+hydration functionality to be more fault-tolerant #3018

Merged
merged 8 commits into from Mar 5, 2020

Conversation

kitten
Copy link
Member

@kitten kitten commented Feb 12, 2020

Fix #3017

@kitten kitten requested a review from probablyup Feb 12, 2020
@kitten kitten changed the title Fix RULE_RE to reduce backtracking Fix RULE_RE to reduce backtracking during Rehydration Feb 12, 2020
@probablyup probablyup changed the title Fix RULE_RE to reduce backtracking during Rehydration revise SSR+hydration functionality to be more fault-tolerant Feb 12, 2020
probablyup
probablyup previously approved these changes Feb 13, 2020
Copy link
Contributor

@probablyup probablyup left a comment

:shipit:

@probablyup
Copy link
Contributor

@probablyup probablyup commented Feb 13, 2020

Published for testing under styled-components@5.0.1-revisedssr

"
.b {}",
"
data-styled.g22[id=\\"idB\\"]{content:\\"nameB,\\"}",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the output double-escaped now when it wasn't before? That seems like an unwanted change.

Copy link
Contributor

@probablyup probablyup Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just a jest snapshot serialization artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants