Skip to content

revise SSR+hydration functionality to be more fault-tolerant#3018

Merged
quantizor merged 8 commits intomasterfrom
fix/rehydration-backtracking
Mar 5, 2020
Merged

revise SSR+hydration functionality to be more fault-tolerant#3018
quantizor merged 8 commits intomasterfrom
fix/rehydration-backtracking

Conversation

@kitten
Copy link
Copy Markdown
Member

@kitten kitten commented Feb 12, 2020

Fix #3017

@kitten kitten requested a review from quantizor February 12, 2020 05:35
@kitten kitten changed the title Fix RULE_RE to reduce backtracking Fix RULE_RE to reduce backtracking during Rehydration Feb 12, 2020
@quantizor quantizor changed the title Fix RULE_RE to reduce backtracking during Rehydration revise SSR+hydration functionality to be more fault-tolerant Feb 12, 2020
quantizor
quantizor previously approved these changes Feb 13, 2020
Copy link
Copy Markdown
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@quantizor
Copy link
Copy Markdown
Contributor

Published for testing under styled-components@5.0.1-revisedssr

"
.b {}",
"
data-styled.g22[id=\\"idB\\"]{content:\\"nameB,\\"}",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the output double-escaped now when it wasn't before? That seems like an unwanted change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just a jest snapshot serialization artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Rehydration regex causing infinite loops for malformed inputs

3 participants