feat: add patch for inserting css in qiankun environment #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
reviewed
Jul 27, 2020
| * this.element.sheet.cssRules and this.sheet.cssRules are not the same pointer application | ||
| * | ||
| */ | ||
| if (this.element.sheet !== this.sheet) { |
There was a problem hiding this comment.
This seems like a different bug that needs to be fixed in the Stylesheet class.
There was a problem hiding this comment.
Thanks,I have solved this problem in qiankun.
There was a problem hiding this comment.
Thanks,I have solved this problem in qiankun.
How did you do that?I have the same problem. Give me some help please~~~
There was a problem hiding this comment.
Thanks,I have solved this problem in qiankun.
How did you do that?I have the same problem. Give me some help please~~~
默认情况下生产环境是使用 CSSOMTag 的方式动态插入样式规则的，与 qiankun 的结合使用会存在问题；
设置 styled-components 加载方式，只要关闭 CSSOMTag 的插入方式，使用 TextTag 插入的方式即可。
在 React 的最外层使用如下设置：
<StyleSheetManager disableCSSOMInjection={true}> //你的应用代码 ...... <StyleSheetManager/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens?
Context
qiankun: 2.0.12:
styled-components: 4.4.1/5.1.0/5.1.1:
Chrome: 83.0.4103.97:
When I debugger, I found that there is an exception here, which is obviously caused when accessing qiankun. The real tag sheet.cssRules does not add css style. In the correct case, this.element.sheet and this.sheet refer to the same reference.
Here are two qiankun styled-componets related issues that have not been resolved
🌹🌹🌹🙏🙏🙏 The twelve sub-applications of our project all have the problem of CSS style loss, so I eagerly hope that the styled-componets organization can give us help. The styled-componets organization can pass this pull request.