feat: pass elementToBeCreated to shouldForwardProp #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me, can you add a changelog entry? |
The internal decision whether to forward a prop is based on the combination of the key and elementToBeCreated, but only the former was passed to shouldForwardProp.
agriffis
force-pushed
the
feat/shouldForwardProp-element
branch
from
67045e4
to
6021916
Compare
|
@probablyup I just force-pushed with the changelog entry. I actually replaced the babel macro changelog entry which doesn't need to be duplicated between 5.2.2 and the unreleased section. |
quantizor
approved these changes
Mar 31, 2021
agriffis
added a commit
to agriffis/styled-components
that referenced
this pull request
Apr 2, 2021
The internal decision whether to forward a prop is based on the combination of the key and elementToBeCreated, but only the former was passed to shouldForwardProp. This is a port of styled-components#3436 to legacy-v5
agriffis
added a commit
to agriffis/styled-components
that referenced
this pull request
Apr 2, 2021
The internal decision whether to forward a prop is based on the combination of the key and elementToBeCreated, but only the former was passed to shouldForwardProp. This is a port of styled-components#3436 to legacy-v5
quantizor
pushed a commit
that referenced
this pull request
Apr 6, 2021
The internal decision whether to forward a prop is based on the combination of the key and elementToBeCreated, but only the former was passed to shouldForwardProp. This is a port of #3436 to legacy-v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to replicate styled-components' internal logic in
shouldForwardProp, because it doesn't have all the information. It only gets the propkey, notelementToBeCreated, and so it can't properly decide in a generic manner whether to forward props.This PR upgrades
shouldForwardPropto includeelementToBeCreatedas a third parameter. This should be backward-compatible with existing code because it only passed two parameters previously.This is especially for when a styled component is called with
as, because that makes the decision of whether to forward props more dynamic than is currently possible to express.This PR should probably also update some documentation somewhere. I can make an additional commit if it otherwise looks good to y'all.