TypeScript: Improve typings of interpolations #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly improves TypeScript support (typings) of interpolations.
Rationale
There're two very different contexts where styles are being created: global (
injectGlobal
,keyframes
functions) and component (styled
function). In the global contexts, functions as interpolations are not accepted. Indeed, there's nothing to use - no props available.So the typings of these functions already make this distinctions,
injectGlobal
andkeyframes
do not accept functions as interpolations.The issue comes up when
css
needs to be used. Since it is meant to be composable and can be used inside both contexts, we need to know what types of interpolations are hidden inside.Changes
css
has been introduced which only takes simple interpolationscss
(which flattens passed array interpolations)Now using function interpolations that came from
css
is also restricted:Upcoming
I'm going to make another PR with better theme support in TypeScript. So you could bundle all the changes in the next release.