Prevent ServerStyleSheet generating empty style tags/elements #4327
+61
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidrezahanafi
changed the title
hamidrezahanafi
changed the title
|
@quantizor would you please take a look at this one? It's going to save much of headaches with SSR |
quantizor
reviewed
Jun 13, 2024
| @@ -16,7 +16,7 @@ export const outputSheet = (sheet: Sheet) => { | |||
|
|
|||
| const names = sheet.names.get(id); | |||
| const rules = tag.getGroup(group); | |||
| if (names === undefined || rules.length === 0) continue; | |||
| if (names === undefined || !names.size || rules.length === 0) continue; | |||
There was a problem hiding this comment.
I'm not sure about this change w.r.t. createGlobalStyle. Could you add a test verifying that cGS usage without any other components works as expected in SSR?
|
Awesome, looks good. Can you settle the prettier job and then I'll approve? |
Done thank you for looking into this! |
quantizor
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this PR not ported over to v6 and with React 18 streaming, it's possible to insert empty style tag in middle of html.
It should fix this issue: #4289
Ported over from: b9e60f7