Fix defaultProps used instead ThemeProvider after initial render

[k15a]

Closes #445

[k15a]

@chadwatson Could you check out if this is working for you?

[chadwatson]

Sure thing. Give me a few minutes.

[diegohaz]

Awesome, maybe we could add a test to cover #445 ?

[chadwatson]

Yes, that fixes the problem! It is still double rendering the child styled component though. Is that a problem?

[k15a]

It's double rendering because you're passing a new object every time and ThemeProvider is checking the reference. In your example they are different so ThemeProvider thinks it is a new Theme.

[k15a]

@diegohaz Do you know how chadwatsons example is different than the test you introduced in #345? I am not seeing any difference.

[diegohaz]

@k15a The difference is that he uses setState after the first render, right?

[xcoderzach]

@k15a I think it's because the props on the Text change without remounting, thus componentWillReceiveProps is called. In this specific case, it's the children prop (the count).

[xcoderzach]

Any time the props on the styled component change without re-mounting this should happen.

[xcoderzach]

Probably something to fix after this gets landed, but it feels a bit precarious to have this same logic duplicated 4x. 😬

[mxstbr-bot]

	Warnings
⚠️	There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

[k15a]

@xcoderzach I wasn't thinking of the children prop. Added tests now.

[k15a]

Probably something to fix after this gets landed, but it feels a bit precarious to have this same logic duplicated 4x. 😬

Basically the whole StyledNativeComponent.js is a duplicate of StyledComponent.js. But it feels wrong anyway^^

[diegohaz]

@k15a Can you confirm if that test fails without the changes on this PR?

[k15a]

Yeah it's failing without the changes.

[mxstbr]

Shipping this asap, sorry for the delay!