New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added react-native-extended-stylesheet #489
Conversation
shripadk
commented
Feb 12, 2017
- Supports REM/Percent units
- Supports Media Queries (Fixes Support media queries with React Native #203)
* Supports REM/Percent units * Supports Media Queries (Fixes styled-components#203)
Generated by 🚫 dangerJS |
/cc @jacobp100 do we want this? |
I’m sort of hesitant about picking one of these libraries, as there’s no defacto standard yet. Bounced an idea off in #504 (which uses some of the changes here) |
@mxstbr @jacobp100 I'll assign this to v3 for now. Are we still interested in adding these features? |
I don't think we'll merge this pr, but we could discuss how we could get this functionality through other ways. |
Support for rem/px specifically would be great, so that there's more portability across native and web. |
@aaronschubert0 that would be in css-to-react-native. We have |
@jacobp100 That's awesome, any word on when styled-components will update to v2 of css-to-react-native? |
In styled-components v2—there's a beta if you want to try it now! |
I'm going to close this PR as it's unlikely we'll merge this into core seeing as nobody has asked for this feature. Thanks for taking the time to make your case! |
/cc @shripadk hey, sorry to disturb you, but can you explain quickly how to use your react-native-extended-styledsheet with a styled-component's style object.. ? |
@mxstbr I really need this feature! we are working on a base code for both web and mobile and we use RN components as a shared package between them .. and we need media queries for web styling, would you plz add this feature / merge this PR ? |