Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added react-native-extended-stylesheet #489

Closed

Conversation

shripadk
Copy link

* Supports REM/Percent units
* Supports Media Queries (Fixes styled-components#203)
@mxstbr-bot
Copy link

mxstbr-bot commented Feb 12, 2017

Fails
🚫 Please include a CHANGELOG entry. You can find it at CHANGELOG.md

Generated by 🚫 dangerJS

@mxstbr
Copy link
Member

mxstbr commented Feb 15, 2017

/cc @jacobp100 do we want this?

@jacobp100
Copy link
Contributor

I’m sort of hesitant about picking one of these libraries, as there’s no defacto standard yet. Bounced an idea off in #504 (which uses some of the changes here)

@kitten kitten added this to the v3.0 milestone Apr 19, 2017
@kitten
Copy link
Member

kitten commented Apr 19, 2017

@mxstbr @jacobp100 I'll assign this to v3 for now. Are we still interested in adding these features?

@jacobp100
Copy link
Contributor

I don't think we'll merge this pr, but we could discuss how we could get this functionality through other ways.

@aaronschubert0
Copy link

Support for rem/px specifically would be great, so that there's more portability across native and web.

@jacobp100
Copy link
Contributor

@aaronschubert0 that would be in css-to-react-native. We have px in v2, but no rem support as of yet.

@aaronschubert0
Copy link

@jacobp100 That's awesome, any word on when styled-components will update to v2 of css-to-react-native?

@jacobp100
Copy link
Contributor

In styled-components v2—there's a beta if you want to try it now!

@mxstbr
Copy link
Member

mxstbr commented Jun 30, 2017

I'm going to close this PR as it's unlikely we'll merge this into core seeing as nobody has asked for this feature.

Thanks for taking the time to make your case!

@jimmydjabali
Copy link

/cc @shripadk hey, sorry to disturb you, but can you explain quickly how to use your react-native-extended-styledsheet with a styled-component's style object.. ?

@heshamabdallah
Copy link

@mxstbr I really need this feature! we are working on a base code for both web and mobile and we use RN components as a shared package between them .. and we need media queries for web styling, would you plz add this feature / merge this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support media queries with React Native
8 participants