[v2] Switch babel over to babel-preset-env #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add transform-react-remove-prop-types in prod, and disable flow-react-proptypes in prod.
|
Hi @philpl, do you think it would be possible to deploy a fix for this when releasing v2? styled-components/babel-plugin-styled-components#33 I have a library bootstrap styled, made on styled that is almost 670kb. I am about to release but i I can't get under 500kb and the library produce a warning. I am almost sure this would reduce the size enough for us. Thanks in advance. |
k15a
reviewed
Apr 22, 2017
| const nodes = document.querySelectorAll(`[${SC_ATTR}]`) | ||
| const nodesLength = nodes.length | ||
|
|
||
| for (let i = 0; i < nodesLength; i += 1) { |
There was a problem hiding this comment.
Any drawbacks of using a for of loop here?
There was a problem hiding this comment.
There shouldn't be :) it's just a tiny bit faster and less hackier than converting that into an array
k15a
approved these changes
Apr 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array.fromFix #684