keyframes better support older iOS (8.x) webkit #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
kitten
approved these changes
Apr 20, 2017
|
LGTM 🚢 Please note, that this is is already working in v2, since we've switched to stylis, which does vendor @Keyframes for us |
|
👍 Thanks for this! This is not only present on IOS devices but older webkit browsers on desktop as well. Looking forward for this in a future version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
styled-componentsin one of our projects we noticed that on older iOS devices (8.x, iPhone 6 and 6 Plus) animations didn't work.After some investigation we've found http://stackoverflow.com/questions/9211261/css3-animation-not-working-in-safari and after some experimentation, the solution suggested in http://stackoverflow.com/a/34013139 worked.
This PR adds changes
keyframesto generate both@keyframes {name}and@-webkit-keyframes {name}.