Fixes for Flow v0.47.0 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v0.47.0 Flow strictly checks function arity. That means you will get an error if you call a function with more arguments than are listed in the function signature. For details see https://flow.org/blog/2017/05/07/Strict-Function-Call-Arity/ There are also some changes to checking React component prop types. The latest Flow will report some errors that previous versions missed. The full changelog is here: https://github.com/facebook/flow/blob/master/Changelog.md#0470
Generated by 🚫 dangerJS |
|
@styled-components/typers |
|
@hallettj maybe merge master and some body merge this PR? |
|
@k15a can you quickly change the changelog :) the entry has landed in the wrong section now |
|
Ohh thought the v2 release is older. I have created a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking the trouble to ship type definitions with your library! There are changes in Flow v0.47.0 that cause Flow to report errors that were not reported in previous versions. I put together this PR so that your users will not see errors when they upgrade to the latest Flow. And I made sure that type-checking still passes with Flow v0.43.1 (the version that you have been using).
As of v0.47.0 Flow strictly checks function arity. That means you will get an error if you call a function with more arguments than are listed in the function signature. For details see https://flow.org/blog/2017/05/07/Strict-Function-Call-Arity/
There are also some changes to checking React component prop types. The latest Flow will report some errors that previous versions missed.
The full changelog is here: https://github.com/facebook/flow/blob/master/Changelog.md#0470