Test: withComponent(...).attrs is not a function #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
That definitely sounds like something that should work! Maybe this is related to #780? |
|
withComponent is a method on styled components and attrs is one on the factory, so this indeed won't work as is :( I'll take a look and see what's required to make this happen |
|
Yeah const Child = Parent.withComponent('a').extend.attrs({
...
})`
...
`or const Child = Parent.extend.attrs({
...
})`
...
`.withComponent('a') |
Should it be possible to add `attrs` after overriding `withComponent`? I
found a test for `withComponent` followed by `extend`, but none for
`attrs`, so I added one:
```js
const Parent = styled.button`
color: red;
`
const Child = Parent.withComponent('a').attrs({
href: '/test'
})``
```
Currently this throws `TypeError: Parent.withComponent(...).attrs is not
a function`.
btmills
force-pushed
the
with-component-attrs-failure
branch
from
c91fc4d
to
3d455b6
Compare
btmills
changed the title
|
Thanks for the tip, @geelen! It sounds like this is the intended behavior, so I've inserted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 This pull request contains a failing test and should not be merged.Edit: Test is no longer failing!Should it be possible to add
attrsafter overridingwithComponent? I found a test forwithComponentfollowed byextend, but none forattrs, so I added one:Currently this throws
TypeError: Parent.withComponent(...).attrs is not a function.I haven't looked into the implementation to see what might be causing this, but if it's an actual bug, I'd be willing to spend some time on a fix given a couple hints about where to start looking!